#60641 closed defect (bug) (fixed)
Update alt text for site icon preview in customizer
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Customize | Keywords: | has-patch |
Focuses: | accessibility | Cc: |
Description
The alt text was improved for the site icon preview as a part of [57713]. These changes should be reflected in the customizer as well.
Change History (7)
This ticket was mentioned in PR #6186 on WordPress/wordpress-develop by @jorbin.
6 months ago
#1
- Keywords has-patch added
6 months ago
#2
@westonruter (because customizer) @swissspidy (because internationalization) I'm wondering if either of you has thoughts on this, specifically the use of the wp.i18n
functions inside of the templates. As these are not actually JS files, I am unsure if this will actually work as expected. I couldn't find any other uses of these functions in src/wp-includes/customize
which is why I'm second-guessing my approach.
@swissspidy commented on PR #6186:
6 months ago
#3
Yeah unfortunately I don‘t think that works, because the JS string extraction only works on JavaScript files, not JS templates inside a PHP file. That meand it couldn‘t be actually translated.
So either keep the existing approach or, if we want to use the JS i18n functions, use them in a JS file and inject into the template as just another variable. For the latter it could be a BC brack if plugins use these templates as well.
Hope that makes sense
6 months ago
#4
I like this approach. If it is also problematic, I think my next method to explore would be putting it in src/js/_enqueues/wp/customize/controls.js
@swissspidy commented on PR #6186:
6 months ago
#5
That should work 👍
Updates both alt text and the description string to match the general settings page.
Trac ticket: https://core.trac.wordpress.org/ticket/60641