Opened 22 months ago
Last modified 7 months ago
#60880 new defect (bug)
Twenty Nineteen: paragraph does not inherit font size from parent block within the editor
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Future Release | Priority: | normal |
| Severity: | normal | Version: | 5.0 |
| Component: | Bundled Theme | Keywords: | has-test-info has-screenshots has-patch |
| Focuses: | ui, css | Cc: |
Description
In Twenty Nineteen Theme, The typography setting of Details Block is not working properly i.e. if we change the size then it is not reflecting on the editor side but it is reflecting in the front end. This is working properly in another theme so I think we have to make the same for this theme also
Here is the recording for better understanding :
https://www.loom.com/share/3f7a1220bd5c4927b343561fd89250b3?sid=9c578532-fee6-47a2-a9ed-896b9b251df5
Attachments (1)
Change History (10)
This ticket was mentioned in Slack in #core-test by ankit-k-gupta. View the logs.
22 months ago
#2
@
22 months ago
- Focuses ui added
- Keywords has-testing-info needs-patch has-screenshots added
- Version set to 6.4.3
@
22 months ago
This visual shows that change in typography does not work as expected for summary in back end.
#3
@
22 months ago
- Focuses css added
- Summary changed from Twenty Nineteen : Details Block Typography is not working properly to Twenty Nineteen: paragraph does not inherit font size from parent block within the editor
- Version changed from 6.4.3 to 5.0
When a Group or Columns block has its own font size and contains Paragraph blocks, the paragraphs do not match the special font size from those parent blocks either. On the front end, the paragraphs match Group, Columns or Details block font sizes.
Version note: Although the Typography setting was not available with WordPress 5.0 and Twenty Nineteen 1.0, entering a has-larger-font-size class for a Columns block already would have had the same issue in the editor. The style-editor.scss stylesheet has targeted the p element in addition to body since initial commit, yet the front-end stylesheet sets font size on the html and body elements instead.
#4
@
18 months ago
The paragraph font size ruleset was added to override 16px in WordPress 5.0 and 5.1 but is unnecessary now.
- To continue supporting old versions, the
font-sizecould be changed toinherit. It could even check the body classes with:where(.branch-5-0, .branch-5-1) .editor-styles-wrapper pif it should target only those versions. The two add up to only 1.02% of all recorded WordPress sites, but the chances of those sites using Twenty Nineteen would be higher than with other WordPress versions. - In WordPress 6.6, deleting the
font-sizeruleset would make the default paragraphs the same22pxsize (taken frombodyin the iframe editor and Classic Editor, or from.editor-styles-wrapperin the non-framed editor). Both #61429 and #61474 have patches that proposed deleting the rule.
#8
@
7 months ago
Reproduction Report
Description
This report validates whether the issue can be reproduced.
Environment
- WordPress: 6.9-alpha-60093-src
- PHP: 8.2.28
- Server: nginx/1.27.5
- Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
- Browser: Chrome 138.0.0.0
- OS: macOS
- Theme: Twenty Nineteen 3.1
- MU Plugins: None activated
- Plugins:
- Test Reports 1.2.0
Actual Results
- ✅ Error condition occurs (reproduced).
Supplemental Artifacts
https://ifnmp28oya.ufs.sh/f/0nfskUTEKfUZJHfZuyYLCDhf8teaWQSMTpvrO75H9y6gsXmj
This ticket was mentioned in PR #9184 on WordPress/wordpress-develop by @rishabhwp.
7 months ago
#9
- Keywords has-patch added; needs-patch removed
Hi @pitamdey
Thank you for reporting the bug. I'm able to replicate the issue mentioned.
Reproduction Report
Description
This report validates the issue can be reproduced.
Environment
Actual Results
Additional Notes
Supplemental Artifacts
Add as Attachment