Make WordPress Core

Opened 2 months ago

Closed 4 weeks ago

Last modified 4 days ago

#61090 closed enhancement (fixed)

Update jQuery UI library to version 1.13.3

Reported by: audrasjb's profile audrasjb Owned by: audrasjb's profile audrasjb
Milestone: 6.6 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: add-to-field-guide good-first-bug
Focuses: javascript Cc:

Description

An update is available for the jQuery UI library. Core currently bundles 1.13.2.
Changelog: https://blog.jqueryui.com/2024/04/jquery-ui-1-13-3-released/

Props @mgol for sharing the info on Slack.

Previously: #56239, #54902

Change History (16)

#1 @audrasjb
2 months ago

  • Keywords early added

#2 @desrosj
8 weeks ago

  • Keywords good-first-bug added

Based on the items listed in the changelog, I'm going to remove the early keyword here. I think this can be reasonably added at any point during the current release cycle.

This ticket was mentioned in PR #6496 on WordPress/wordpress-develop by @khokansardar.


8 weeks ago
#3

  • Keywords has-patch added; needs-patch removed

Updates jQuery UI to the latest version v1.13.3

Trac ticket: #61090

#4 @khokansardar
8 weeks ago

  • Keywords needs-testing added

@khokansardar commented on PR #6496:


8 weeks ago
#5

The script version also needs to be updated in script-loader.php

Updated.

#6 @swissspidy
6 weeks ago

See also this note about the upcoming jQuery UI 1.14:

The list of breaking changes will be short and mostly boil down to:

  • dropping support for legacy browsers (mostly IE & Edge Legacy); only testing on the latest versions of Chrome, Firefox, Safari & Edge - but I suspect Drupal already doesn't support them?
  • switching the default of jQuery.uiBackCompat from true to false - it's easy to overwrite that back if you need for backwards compatibility
  • only testing on the latest version of jQuery within each major (1.x, 2.x, 3.x I 4.x) - currently, each minor update is being tested

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


6 weeks ago

#8 @desrosj
6 weeks ago

  • Keywords commit added; early removed

@swissspidy any objection to committing this and then creating a new ticket for 1.14 since that release is currently in beta?

#9 @swissspidy
6 weeks ago

Sounds good to me!

#10 @audrasjb
4 weeks ago

  • Owner set to audrasjb
  • Status changed from new to assigned

Self assigning for commit.

#11 @audrasjb
4 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58218:

External Libraries: Update the jQuery UI library to version 1.13.3.

For more information on the changes included, see https://blog.jqueryui.com/2024/04/jquery-ui-1-13-3-released/.

Props audrasjb, desrosj, khokansardar, swissspidy.
Fixes #61090.

#12 @audrasjb
4 weeks ago

  • Keywords has-patch needs-testing commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this ticket as the following changes in $vendor_scripts_versions were not supposed to ship with this changeset:
https://core.trac.wordpress.org/changeset/58218/trunk/src/wp-includes/script-loader.php

#13 @audrasjb
4 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 58219:

External Libraries: Revert some unwanted changes after [58218].

This reverts some unwanted changes related to react and react-dom versions in $vendor_scripts_versions`.

Follow-up to [58218].

Unprops audrasjb.
Fixes #61090.

#15 @azaozz
4 days ago

Just FYI: WordPress uses a "special" build of jQuery UI that allows separate components to be enqueued through the script loader (mostly for use by plugins) and optimizes the loading a bit. Also some "special" CSS but that seems to be unaffected.

This seems to be working fine but still thinking it would be good to have "special testing calls" to test this update during 6.6 beta and RC, just in case.

Last edited 4 days ago by azaozz (previous) (diff)

This ticket was mentioned in Slack in #core by juanmaguitar. View the logs.


4 days ago

Note: See TracTickets for help on using tickets.