Make WordPress Core

Opened 5 weeks ago

Last modified 4 weeks ago

#61219 assigned enhancement

Simplify add_new_item labels for core post types

Reported by: jameskoster's profile jameskoster Owned by: audrasjb's profile audrasjb
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: 2nd-opinion has-patch
Focuses: ui, accessibility, administration Cc:

Description

If "new" is removed from the add_new_item string for core post types then button labels can be shortened, and title case (which is inconsistent with Gutenberg buttons) sidestepped.

  • "Add New Post" → "Add Post"
  • "Add New Page" → "Add Page"
  • "Add New User" → "Add User"
  • "Add New Theme" → "Add Theme"
  • And so on.

It's most problematic in the Site Editor where labels like "Add New Template Part" feel unnecessarily verbose.

What do y'all think?

Change History (8)

#1 @audrasjb
5 weeks ago

  • Keywords 2nd-opinion needs-patch added
  • Owner set to audrasjb
  • Status changed from new to assigned

Just adding my two cents: on fr_FR as well as in several other locales, we decided a bunch of years ago to strip the notion of "new" in our translation.

Example: Instead of Ajouter une nouvelle page for Add new page we have Ajouter une page which works very well and is also less verbose. People probably understand that when they "add" a post or a user this will probably be a new one 🙂

Conclusion: this is a +1 on my side.
Not sure if this will work for our en_US fellow contributors BTW 😊

#2 @sabernhardt
5 weeks ago

Related: #47125, GB53984

This ticket was mentioned in PR #6585 on WordPress/wordpress-develop by @ntsekouras.


4 weeks ago
#3

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/61219

If "new" is removed from the add_new_item string for core post types then button labels can be shortened, and title case (which is inconsistent with Gutenberg buttons) sidestepped.

"Add New Post" → "Add Post"
"Add New Page" → "Add Page"
"Add New User" → "Add User"
"Add New Theme" → "Add Theme"
And so on.

It's most problematic in the Site Editor where labels like "Add New Template Part" feel unnecessarily verbose.

Description is from the ticket.

#4 @afercia
4 weeks ago

  • Component changed from Posts, Post Types to Administration
  • Focuses ui accessibility administration added

and title case (which is inconsistent with Gutenberg buttons) sidestepped.

Regarding the casing, I would say it's Gutenberg that is inconsistent with Core. This was previously raised in the Gutenberg repository, see https://github.com/WordPress/gutenberg/issues/53984

Regarding removing 'new' I have no strong opinions. However, it's not just about post type labels. Such a change should be done for all the WordPress objects (tazonomies, users, etc.) labels that contain 'new'. For example:

  • 'Add New Tag'
  • 'Add New Category'
  • 'Add New Link Category'
  • 'Add New Link'
  • 'Add New Plugin'
  • 'Add New Theme'
  • 'Add New User' / 'Add New Users'
  • 'Add New Site'
  • 'Add New Comment'
  • 'Add New Header Image'
  • 'Add New Image'
  • Any other label I may be missing.

There is also the 'new_item' label e.g. in the admin bar on multisite and I guess other palces, which is for example:

  • 'New Post'
  • 'New Changeset'
  • 'New Template'

This label should be updated as well for consistency. I'm not sure it would be great to have the UI sometimes show 'Add Template' and sometimes 'New Template'.

It is also worth considering a change like this would impact custom post types / taxonomies added by plugins. All extenders should be informed to update their labels but in the meantime users would likely see a mixed pattern in the UI e.g. 'Add Post', 'Add Page', 'Add New Product', 'Add New Book', etc.

@youknowriad commented on PR #6585:


4 weeks ago
#5

This LGTM. I saw that we have three similar labels for taxonomies too. I wonder if we should align these as well.

#6 @afercia
4 weeks ago

To get an idea of how post types / taxonomies labels changes may impact plugins, see #60045.
That's specific to the change introduced in #47125 in the scenario where custom posts omit one of the labels. In that case, WordPress will use the default labels which include the words 'Post' and 'Page'.
This is not to say I'm opposed to this proposed change. However, labels changes should be carefully considered.

@peterwilsoncc commented on PR #6585:


4 weeks ago
#7

More importantly, if we go with removing 'new' I would like to see this change made consistently throughout the entire codebase. It's not just about post type labels There's way more to change.

I agree with @afercia that if this change is to be made it ought to be done throughout the code base: add new plugin, add new theme and even the very well hidden add new link.

I think this and https://github.com/WordPress/gutenberg/issues/53984 can be solved independently and if anything the upstream ticket is actually an issue in WordPress-Develop if the strings aren't making it through to the editor interface.

@ntsekouras commented on PR #6585:


4 weeks ago
#8

Agreed about consistency and making this change everywhere. I've update lots of files and hopefully haven't missed anything.

Note: See TracTickets for help on using tickets.