Make WordPress Core

Opened 2 years ago

Last modified 22 months ago

#61666 new enhancement

Extra margin in tablet and mobile login button in admin login

Reported by: trushaamin Owned by:
Priority: normal Milestone: Awaiting Review
Component: Login and Registration Version: 3.8
Severity: minor Keywords: has-patch
Cc: Focuses: ui, css

Description

I have just found one issue in admin login there is an extra margin of 4px from the bottom-side of the login button on mobile and tablet.

Attachments (2)

Login issue.png​ (30.1 KB ) - added by trushaamin 2 years ago.
61666.diff​ (393 bytes ) - added by modi2918 2 years ago.
Patch file for solution

Download all attachments as: .zip

Change History (8)

#1 @deeppatel8950
2 years ago

Same issue with the button margin on responsive devices.

@modi2918
2 years ago

Patch file for solution

#2 @modi2918
2 years ago

  • Component Administration → Login and Registration

#3 follow-up: @sabernhardt
2 years ago

  • Keywords has-patch changes-requested 2nd-opinion added; needs-patch removed
  • Severity normal → minor
  • Type defect (bug) → enhancement
  • Version 6.6 → 3.8

Hi and thanks for the report!

Editing the buttons.css styles can affect many other parts of the admin UI, so that stylesheet needs to keep the margin (which was originally added in [26134]).

It might be worth setting the .login .submit .button bottom margin to zero for most uses of wp-login.php. I was most concerned about the password-reset form, but both the Generate Password and Save Password buttons have their own 6-pixel bottom margin to give space between them when stacked vertically.

#4 @dharmik1455
2 years ago

There is no need for a 4px bottom margin on this button. Upon removing the 4px margin, the design remains intact. I have checked the design and everything looks good.

#5 in reply to: ↑ 3 @trushaamin
2 years ago

I think @dharmik1455 is right, when we remove the 4px margin after no any design break. sabernhardt:

Hi and thanks for the report!

Editing the buttons.css styles can affect many other parts of the admin UI, so that stylesheet needs to keep the margin (which was originally added in [26134]).

It might be worth setting the .login .submit .button bottom margin to zero for most uses of wp-login.php. I was most concerned about the password-reset form, but both the Generate Password and Save Password buttons have their own 6-pixel bottom margin to give space between them when stacked vertically.

Last edited 2 years ago by trushaamin (previous) (diff)

#6 @trushaamin
22 months ago

  • Keywords needs-design-feedback changes-requested 2nd-opinion removed
Note: See TracTickets for help on using tickets.