The margins above and below the login form are not the same

[audrasjb]

Hello, thank you for the report.

This was modified in purpose in #61013 to remove the extra bottom padding on the form.

Except for the different padding values –which is not really an issue–, what is the functional issue you wanted to report?

Thank you

[audrasjb]

Oh sorry it is not related to #61013, which is about (internal) paddings and not (external) margins :)

Let's reformulate my question then: Having a different margin at the bottom of an element may be useful to visually separate the element at the bottom. Do you think these different spacings between the element are a causing an issue?

[priyank9033]

@audrasjb I think there is a difference of 1px at the bottom of the logo. We can keep the top margin as it is on the form for UI purposes.

[deeppatel8950]

@audrasjb I think @priyank9033 is right. We can reduce the bottom margin of the logo by 1px and keep the top margin of the form as it is.

[viralsampat]

I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.

[viralsampat]

After resolved:

[vijaysinh9094]

logo margin issue fixed as per last discussion.

[vijaysinh9094]

After making changes, the logo margin is reduce by 1px as per the last discussion.

[sabernhardt]

I agree to change the logo's bottom margin to 24 pixels.

[26072] included both the 25px bottom margin on the logo link and 24px for the top margin on the #nav container, but most pixel-based measurements on the login page are in multiples of 4.

@vijaysinh9094 Your 61667.diff​ is saved in UTF-16. Could you re-create the patch using UTF-8? (If not, I could upload a patch.)

[vijaysinh9094]

@sabernhardt I have updated the patch to change the bottom margin of the logo to 24 pixels to maintain consistency with other pixel-based measurements on the login page, which are typically in multiples of 4. The previous patch included a 25px bottom margin, but it was identified that this measurement did not align with the common practice on the login page. Additionally, the patch file 61667.diff was previously saved in UTF-16 encoding. I have recreated and saved the new patch file in UTF-8 encoding to ensure compatibility and consistency with the project requirements.

[sabernhardt]

Thanks!