Unused array_merge call?

[kkmuffme]

​https://github.com/WordPress/wordpress-develop/blame/trunk/src/wp-includes/script-loader.php#L616

This is redundant since it's not used if not assigned.

[SergeyBiryukov]

Good catch! Added in [44265] / #45348.

https://core.trac.wordpress.org/ticket/61754
This PR removes unused Array Merge call from script-loader.php

[davidbaumwald]

In 59033:

Script Loader: Remove unused array_merge.

This change removes an unused array_merge that was added in [44265].

Props kkmuffme, SergeyBiryukov, akshat2802.
Fixes #61754.

[SergeyBiryukov]

I believe the intention in [44265] / #45348 was to actually merge the arrays, otherwise the wp_editor_settings filter is applied in wp_tinymce_inline_scripts(), but the result is not used anywhere:

/** This filter is documented in wp-includes/class-wp-editor.php */
$editor_settings = apply_filters( 'wp_editor_settings', array( 'tinymce' => true ), 'classic-block' );

[davidbaumwald]

@SergeyBiryukov Thanks! I'll revert r59033 and re-review.

[davidbaumwald]

In 59047:

Script Loader: Revert removing unused array_merge.

Code is poetry, until it isn’t.

Unprops davidbaumwald.
See #61754.

[TobiasBg]

@davidbaumwald: I think [59047] didn't revert [59033] but a piece of [59046]?

[SergeyBiryukov]

In 59051:

Script Loader: Restore user-profile.js dependencies after an accidental revert.

Follow-up to [59033], [59046], [59047].

Props TobiasBg.
See #61754.

[SergeyBiryukov]

In 59074:

Editor: Restore the merging of TinyMCE settings in wp_tinymce_inline_scripts().

This ensures that the function applies the wp_editor_settings filter and merges the resulting array with the rest of TinyMCE init settings.

Includes a unit test to verify that the settings are merged correctly after adding the assignment of array_merge() result that was missed in the initial commit.

Follow-up to [44265], [59033].

Props kkmuffme, akshat2802, davidbaumwald, SergeyBiryukov.
Fixes #61754.

Thanks for the PR! Merged in r59033 and r59074.