Twenty Eleven & Twenty Twelve: Code block does not adjust font size with block settings

[viralsampat]

Hello Team,

I have reviewed "code" block on the twenty eleven & twenty twelve themes and found that the "typography" is not working when we trying to change it.

I already created the same issue for twenty thirteen theme: #61697

Here, I have provided its video and screenshot:

I think that it should be change based on selection.

Thanks,

[viralsampat]

Twenty-eleven editor side

[viralsampat]

Twenty-eleven front-end side

[viralsampat]

Twenty-twelve editor side

[viralsampat]

Twenty-twelve front-end side.

[viralsampat]

Twenty-eleven issue vide:

[viralsampat]

Twenty-twelve issue video:

[sabernhardt]

inherit font size when code is inside pre

[sabernhardt]

As with Twenty Thirteen (#61697), Twenty Eleven and Twenty Twelve set the same font size for both the pre and code elements.

With 61753.patch​, a code element would inherit the font size when it is nested inside a pre tag. In Twenty Twelve, this only applies within entry-content or comment-content; code in a widget honors the block's font size without any adjustment.

[viralsampat]

I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.

[viralsampat]

After resolved issue twenty eleven editor

[viralsampat]

After resolved issue twenty eleven front-end

[viralsampat]

After resolved issue twenty twelve editor

[viralsampat]

After resolved issue twenty twelve front-end.

[sabernhardt]

Both patches do basically the same thing, but

1. these themes do not have an empty line between rulesets and
2. 61753.patch​ adds font-size: inherit within the _existing_ ruleset for .entry-content pre code, .comment-content pre code in Twenty Twelve's style.css.

[sabernhardt]

Other themes: Twenty Fourteen through Twenty Twenty-Four already adjust the font size for Code blocks according to the block setting. Twenty Ten does not change, but that theme can have trouble with any font size adjustment due to pixel-based line-height values.

[karmatosed]

Thank you everyone, I am going to assign this to myself to test with a look to then commit.

[karmatosed]

In this case I am looking to add the patch by @sabernhardt because it doesn't have extra lines that yours does @viralsampat. Those lines do not seem needed which means it's better to go with that one when both patches look the same.

This also has been noted as a difference:

61753.patch​ adds font-size: inherit within the _existing_ ruleset for .entry-content pre code, .comment-content pre code in Twenty Twelve's style.css.

I am going to go ahead and look to commit, both of you will get props though and both patches were the same in contents, just had some formatting differences.

[karmatosed]

In 58816:

Multiple themes: Fixes Code block not adjusting to font size changes.

This resolves the Code block not changing when the font sizes are switched in Twenty Eleven and Twenty Twelve. The solution is the same as used for other code block adjustments for font sizes.

Props viralsampat, sabernhardt.
Fixes #61753.