Make WordPress Core

Opened 2 months ago

Last modified 11 days ago

#61881 new defect (bug)

Twenty Fourteen: Button block background color is mismatch

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: css Cc:

Description

Hello Team,

I have reviewed the "Button" block and found that it's background is not same on editor side & front-end site into the twenty-fourteen theme.

I think that it should be same on both the sides(Editor & Front-end).

For better understanding, I have attached it's screenshots:

Thanks,

Attachments (5)

twenty-fourteen-button-block-editor.png (164.6 KB) - added by viralsampat 2 months ago.
Back-end:
twenty-fourteen-button-block-front-end.png (185.6 KB) - added by viralsampat 2 months ago.
Front-end:
61881.patch (724 bytes) - added by viralsampat 2 months ago.
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.
after-resolved-twenty-fourteen-button-block-editor.png (148.7 KB) - added by viralsampat 2 months ago.
After resolved issue Back-end:
after-resolved-twenty-fourteen-button-block-front-end.png (173.2 KB) - added by viralsampat 2 months ago.
After resolved issue front-end:

Download all attachments as: .zip

Change History (10)

@viralsampat
2 months ago

I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.

@viralsampat
2 months ago

After resolved issue Back-end:

@viralsampat
2 months ago

After resolved issue front-end:

#1 @sabernhardt
8 weeks ago

61881.patch would correct the default background color for both the Fill and Outline styles of the Button block in the iframe editor. If someone selects a different background color, that likewise would be correct in the iframe with the patch. It could be worth committing that to support WordPress 6.6 and/or earlier.

However, the fundamental issue is that the editor prints the classic-themes-css fallback styles inside the body element, after the editor-blocks stylesheet in the head. I think both need to be enqueued in the enqueue_block_assets hook (#61591 would address the theme's part, #61892 would move the Core styles).

Last edited 8 weeks ago by sabernhardt (previous) (diff)

#2 @karmatosed
7 weeks ago

  • Keywords changes-requested added; dev-feedback removed

It looks like this patch needs changes so marking for that.

#3 @hellofromTonya
4 weeks ago

  • Version 6.6.1 deleted

I'm doing triage today for bugs reported on 6.6.1 or 6.6.2 (i.e. via Version) and then updating ticket information. Resetting the Version as 6.6.1 did not ship changes for this theme or classic-themes-css fallback styles.

#4 @imranhasanraaz
2 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/61881/61881.patch

Environment

  • WordPress: 6.7-alpha-58576-src
  • PHP: 8.2.23
  • Server: nginx/1.27.1
  • Database: mysqli (Server: 8.0.39 / Client: mysqlnd 8.2.23)
  • Browser: Chrome 129.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Fourteen 4.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

After Applying patch

Editor : https://prnt.sc/hE8S1wWNJFON
Frontend : https://prnt.sc/uyaSWzwy0av0

Last edited 2 weeks ago by imranhasanraaz (previous) (diff)

#5 @sabernhardt
11 days ago

  • Keywords changes-requested removed
Note: See TracTickets for help on using tickets.