The .json files with theme translations are loaded only if they are present in the plugins path

[itapress]

Hello.

Following this change: ​https://github.com/WordPress/WordPress/commit/54a61e9c9b36970fe18b33fe2c35a5823617ffca

Theme translation .json files are loaded only if present in the "wp-content/languages/plugins/" path and not from the “wp-content/languages/themes/” path.

I discovered the problem and tested it with the Dutch translation of the Kadence and Astra themes.

Thanks.

[swissspidy]

Thanks for your report! I will look into it.

The change in https://core.trac.wordpress.org/ticket/60891 / https://core.trac.wordpress.org/changeset/57922 was not tested enough with themes that load script translations. It caused a regression where WP tried to look up script translations for a theme in wp-content/languages/plugins.

Even when using a custom WP_PLUGIN_DIR/WP_PLUGIN_URL configuration, we should always use the correct path for themes and plugins alike.

To-do:

• [ ] Add unit tests

Trac ticket: https://core.trac.wordpress.org/ticket/62016

[swissspidy]

@itapress Does the ​proposed patch fix the issue for you?

[itapress]

@swissspidy I tried this fix and everything works fine for me. Thanks!

[swissspidy]

In 59126:

I18N: Fix script languages path for themes.

Remove hardcoded path added in [57922] which ignored the fact that themes can also use script translations.
They should not be affected even if plugins are installed outside the typical wp-content/plugins location.

Props itapress, swissspidy.
Fixes #62016.

Committed in https://core.trac.wordpress.org/changeset/59126

[swissspidy]

#62157 was marked as a duplicate.

[swissspidy]

#62155 was marked as a duplicate.

@swissspidy Could you have a look at whether this is a viable alternative approach?

Replace the changes in this commit with only the following line:
​Line 1210 $languages_path = WP_LANG_DIR . '/' . $relative[0];

At least this fixes a regression reported 2 weeks ago: https://core.trac.wordpress.org/ticket/62155

No, this just reintroduces the original bug.

Ensure correct languages path when using a custom WP_PLUGIN_DIR / WP_PLUGIN_URL configuration, a custom theme root, and/or using Multisite with subdirectories.

Trac ticket: https://core.trac.wordpress.org/ticket/62016

@them-es #7562 should address this, please test

@swissspidy Yes that seems to fix the reported Multisite regression. Thank you for the quick turnaround 👍

[staurand]

Reproduction Report

Description

The issue can be reproduced in the latest stable WordPress version (6.6.2).

Environment

• WordPress: 6.6.2
• PHP: 8.1.8
• Server: Apache/2.4.53 (Debian)
• Database: mysqli (Server: 5.7.43 / Client: mysqlnd 8.1.8)
• Browser: Firefox 131.0
• OS: macOS
• Theme: Twenty Twenty Four child theme
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.1.0

Actual Results

1. ✅ Text is not translated (See "Translated?" should be "Traduit!")

Additional Notes

• Tested with a child theme of Twenty Twenty Four loading js file that should alerts a translated text on Multisite (main site + sub site)

Supplemental Artifacts

[staurand]

Test Report

Description

The issue is fixed with ​https://github.com/WordPress/wordpress-develop/pull/7562

Environment

• WordPress: 6.5-beta2-57671-src
• PHP: 8.1.8
• Server: Apache/2.4.53 (Debian)
• Database: mysqli (Server: 5.7.43 / Client: mysqlnd 8.1.8)
• Browser: Firefox 131.0
• OS: macOS
• Theme: Twenty Twenty Four child theme
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.1.0

Actual Results

1. ✅ The text is translated

Additional Notes

• Tested with a child theme of Twenty Twenty Four loading js file that should alert a translated text on Multisite (main site + sub site)

Supplemental Artifacts

https://core.trac.wordpress.org/attachment/ticket/62016/ticket-62016-patched-main-site.png
https://core.trac.wordpress.org/attachment/ticket/62016/ticket-62016-patched-sub-site.png

[swissspidy]

In 59264:

I18N: Fix script languages path on Multisite.

This is a follow-up to [59126] (itself a follow-up to [57922]), which caused a regression when determining the right path when loading script translations.

Props swissspidy, themes-1, staurand.
Fixes #62016.

Committed in https://core.trac.wordpress.org/changeset/59264

[hupe13]

Thank you for fixing! Works for me in 6.7-RC1.