WordPress.org
Get WordPress

Make WordPress Core

Opened 8 months ago

Closed 7 months ago

Last modified 7 months ago

#62098 closed defect (bug) (fixed)

Twenty Fourteen : PHPCS Fixes

Reported by: pitamdey's profile pitamdey Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

In theme Twenty Fourteen,
I have found a few PHPCS errors like

  • Inline comments must end in full stops, exclamation marks, or question marks
  • There must be exactly one blank line after the file comment

I have applied a patch which will fix this issue.

Attachments (1)

phpcsfixes.patch​ (6.6 KB) - added by pitamdey 8 months ago.
Patch for this issue

Download all attachments as: .zip

Change History (7)

@pitamdey
8 months ago

Patch for this issue

#1 @pitamdey
8 months ago

This point is also covered

  • There must be no blank lines after the class comment

This ticket was mentioned in ​PR #7421 on ​WordPress/wordpress-develop by ​@dhruvang21.
8 months ago #2

#3 @jrf
8 months ago

  • Focuses coding-standards added; php-compatibility removed

#4 @SergeyBiryukov
8 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.7

#5 @SergeyBiryukov
7 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 59158:

Twenty Fourteen: Fix various PHPCS issues.

  • Inline comments must end in full stops, exclamation marks, or question marks.
  • There must be exactly one blank line after the file comment.

Follow-up to [24832], [25023], [25088], [25090], [25213], [51045].

Props pitamdey, dhruvang21, aristath.
Fixes #62098.

​@SergeyBiryukov commented on ​PR #7421:
7 months ago #6

Thanks for the PR! Merged in r59158.

Note: See TracTickets for help on using tickets.