WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#62098 closed defect (bug) (fixed)

Twenty Fourteen : PHPCS Fixes

Reported by: pitamdey Owned by: SergeyBiryukov
Priority: normal Milestone: 6.7
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: coding-standards

Description

In theme Twenty Fourteen,
I have found a few PHPCS errors like

  • Inline comments must end in full stops, exclamation marks, or question marks
  • There must be exactly one blank line after the file comment

I have applied a patch which will fix this issue.

Attachments (1)

phpcsfixes.patch​ (6.6 KB ) - added by pitamdey 2 years ago.
Patch for this issue

Download all attachments as: .zip

Change History (7)

@pitamdey
2 years ago

Patch for this issue

#1 @pitamdey
2 years ago

This point is also covered

  • There must be no blank lines after the class comment

This ticket was mentioned in ​PR #7421 on ​WordPress/wordpress-develop by ​@dhruvang21.
2 years ago #2

#3 @jrf
2 years ago

  • Focuses coding-standards added; php-compatibility removed

#4 @SergeyBiryukov
2 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 6.7

#5 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 59158:

Twenty Fourteen: Fix various PHPCS issues.

  • Inline comments must end in full stops, exclamation marks, or question marks.
  • There must be exactly one blank line after the file comment.

Follow-up to [24832], [25023], [25088], [25090], [25213], [51045].

Props pitamdey, dhruvang21, aristath.
Fixes #62098.

​@SergeyBiryukov commented on ​PR #7421:
2 years ago #6

Thanks for the PR! Merged in r59158.

Note: See TracTickets for help on using tickets.