[ wp-includes/shortcodes.php - do_shortcode() ] - fallback in case content is not a string

[riccardodicurti]

Good morning everyone, while working on a project on php 8, I found that a plugin was passing content to do_shortcode() that was not a string and this led to an error.

In my opinion, it would therefore be better to add a check, like

if(! is_string($content) ) { return $content; }

, in order to check what is then passed str_contains().

Thanks in advance.

https://core.trac.wordpress.org/ticket/62454

[umeshsinghin]

Hi,
As per the suggested changes, I have implemented the fixes. Please review and confirm.

[riccardodicurti]

Ciao @umeshsinghin, thanks for the pull request. I have tested it with a couple of shortcodes and see no problems.

[SergeyBiryukov]

Hi there, thanks for the ticket!

This looks similar to the discussions in #17299, #18927, #23767, #27489, and #48035 (those tickets are unrelated to this particular function, but they suggest a similar enhancement for other functions). The consensus was that we should not hide warnings caused by developer errors, unless there is a strong reason. It would just make debugging harder.

If a valid parameter generates a warning, we should certainly fix that. However, in case of an invalid parameter, I think the warning (or an error on PHP 8.0+) is to be expected.