Make WordPress Core

Opened 7 weeks ago

Last modified 6 weeks ago

#62744 new enhancement

Twenty Seventeen: Quote block Appearance settings do not affect citation

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: 2nd-opinion
Focuses: css Cc:

Description

Steps to reproduce the issue :-

  1. Activate Twenty Seventeen theme.
  2. Choose Quote block.
  3. Add some text and citation.
  4. Now change the font family from appearance.

Yu can able to see that your applied font family only works for the text and not for the citation text both the side editor and front.

Attachments (2)

62744.patch (913 bytes) - added by nidhidhandhukiya 6 weeks ago.
62744.2.patch (951 bytes) - added by nidhidhandhukiya 5 weeks ago.
Hello @sabernhardt I have updated the patch as per your suggestion.

Download all attachments as: .zip

Change History (4)

#1 @sainathpoojary
6 weeks ago

Hey @nidhidhandhukiya,

I was able to reproduce the issue by following the steps provided. However, I believe this might be the expected behavior, as similar styling can be observed in other themes. Additionally, the font weight for citations often differs from that of quotes.

That said, I do agree that having a control to customize the font weight of citations would be a useful addition.

Video: https://utfs.io/f/PL8E4NiPUWyORiCprmdTu5OnjW2XKY0IRv1P9lgoTaLbV4qy

#2 @sabernhardt
6 weeks ago

  • Focuses css added
  • Keywords 2nd-opinion added
  • Summary changed from Twenty Seventeen - Quote block appearance not work for ciation. to Twenty Seventeen: Quote block Appearance settings do not affect citation
  • Type changed from defect (bug) to enhancement
  • Version 6.7.1 deleted

62744.patch would change the styles for every Quote block that does not assign a special font-weight and/or font-style in Appearance settings. It even would change styles for sites that do not use the block editor at all.

Someone who has assigned a different Appearance on the Quote block might have intended to apply that style to the inner Paragraph only. (The custom style is currently the same whether it is set on the Quote block or its inner Paragraph block.)

If someone assigns an Appearance setting on both the Quote block and an inner block, that could indicate a desire to change the citation style. The following is quite complex but possibly worth trying:

:root :where(.wp-block-quote[style*="font-weight"] *[style*="font-weight"]) ~ cite {
	font-weight: inherit;
}
:root :where(.wp-block-quote[style*="font-style"] *[style*="font-style"]) ~ cite {
	font-style: inherit;
}

@nidhidhandhukiya
5 weeks ago

Hello @sabernhardt I have updated the patch as per your suggestion.

Note: See TracTickets for help on using tickets.