Make WordPress Core

#63037 closed defect (bug) (fixed)

Missing space before "checked" attribute

Reported by: kkmuffme Owned by: audrasjb
Priority: normal Milestone: 6.8
Component: General Version:
Severity: trivial Keywords: has-patch
Cc: Focuses:

Description

/wp-admin/edit-comments.php?comment_status=moderated

Currently like:

<label><input class="hide-column-tog" name="author-hide" type="checkbox" id="author-hide" value="author"checked=checked />Author</label>

missing space before checked attribute

Change History (7)

This ticket was mentioned in PR #8433 on WordPress/wordpress-develop by @kkmuffme.


19 months ago
#1

  • Keywords has-patch added

#2 @audrasjb
19 months ago

  • Milestone Awaiting Review6.8
  • Owner set to audrasjb
  • Status newreviewing

@audrasjb commented on PR #8433:


19 months ago
#3

Thanks @kkmuffme I added a small suggestion, but I'm going to commit it directly on svn

#4 @audrasjb
19 months ago

  • Resolutionfixed
  • Status reviewingclosed

In 59889:

General: Add missing space before checked attributes in various WP_Screen functions.

Props kkmuffme, audrasjb.
Fixes #63037.

#5 @kkmuffme
19 months ago

  • Resolution fixed
  • Status closedreopened

Turns out this was correct already before, there was an issue on my end that my IDE messed up the output function.
Please revert this, since it's unnecessary and already correct.

#6 @audrasjb
19 months ago

Indeed, this was incorrect since __checked_selected_helper() actually adds a space before the attribute. Reverting this changeset has a low priority but I'll handle it.

#7 @audrasjb
19 months ago

  • Resolutionfixed
  • Status reopenedclosed

In 59941:

General: Remove extra spaces added before checked() functions used in WP_Screen class.

This reverts [59889] as __checked_selected_helper() actually adds a leading space before the checked attribute.

Props kkmuffme.
Unprops audrasjb.
Fixes #63037.

Note: See TracTickets for help on using tickets.