WordPress.org
Get WordPress

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#63160 closed defect (bug) (fixed)

Twenty Eleven: improve documentation for twentyeleven_attachment_size filter

Reported by: sabernhardt's profile sabernhardt Owned by: audrasjb's profile audrasjb
Milestone: 6.8 Priority: normal
Severity: normal Version: 3.7
Component: Bundled Theme Keywords: has-patch
Focuses: docs Cc:

Description

Since changeset 25625, the twentyeleven_attachment_size docblock has described its parameter as "height and width attachment size dimensions," but the filter only adjusts the image width.

An inline comment clarifies that the image height has a 1024px limit, and I think that information could fit within the filter's docblock.

Attachments (1)

63160.diff​ (1.2 KB) - added by sabernhardt 5 months ago.

Download all attachments as: .zip

Change History (6)

@sabernhardt
5 months ago

#1 @sabernhardt
5 months ago

  • Keywords has-patch added

#2 @audrasjb
5 months ago

  • Milestone changed from 6.9 to 6.8

Thanks for the ticket and patch. Makes sense to me. Given it's a Docs only change, let's fix this in 6.8.

#3 @audrasjb
5 months ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 60077:

Twenty Eleven: Improve documentation for twentyeleven_attachment_size filter.

Follow-up to [25625].

Props sabernhardt.
Fixes #63160.

#4 @SirLouen
5 months ago

  • Keywords has-patch removed

#5 @SirLouen
5 months ago

  • Keywords has-patch added

My bad. I notice now can't edit a post's keyword changes. Restoring it back

Note: See TracTickets for help on using tickets.