Opened 12 months ago
Closed 5 weeks ago
#63161 closed defect (bug) (duplicate)
Unable to Navigate Autocomplete Suggestions via Keyboard in Theme & Plugin File Editor
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | 4.9 |
| Component: | General | Keywords: | has-patch |
| Focuses: | accessibility | Cc: |
Description
This issue affects the built-in Theme and Plugin File Editor within the WordPress admin area.
When editing a file inside the editor, keyword suggestions appear as we type. However, there is a problem specifically with .php files:
- When typing in a
.phpfile, the autocomplete suggestion list appears. - Attempting to navigate the suggestions using the up/down arrow keys does not work as expected.
- The selection remains stuck on the first suggested item, making it impossible to move through the list via keyboard input.
- However, when selecting suggestions using the mouse cursor, they work as expected.
Here’s a screen recording demonstrating the issue : (https://www.awesomescreenshot.com/video/37998611?key=262d499496bfcc778da2e6975eaaf248)
This issue is only present in .php files. Other file types such as .css, .js, and .html work correctly and allow navigation via keyboard input.
Steps to Reproduce:
- Open the WordPress Theme or Plugin File Editor.
- Edit a
.phpfile and start typing a function or keyword that triggers the autocomplete suggestion list. - Try navigating the suggestion list using the up/down arrow keys.
- Notice that the selection remains stuck on the first item and does not move.
- Now, try selecting a suggestion with the mouse cursor—it works fine.
Expected Behavior:
- The up/down arrow keys should allow smooth navigation through the autocomplete suggestions, just like they do for
.css,.js, and.htmlfiles.
Actual Behavior:
- Keyboard navigation is broken for
.phpfiles, preventing users from selecting suggestions efficiently.
Environment Details:
- WordPress Version: 6.7.2
- Browser: Chrome, Firefox
- Theme & Plugins: Tested with default theme Twenty Twenty-One and no plugin active.
Would appreciate further insights or confirmation from the Core team on this. Thank you!
Attachments (1)
Change History (18)
This ticket was mentioned in PR #8598 on WordPress/wordpress-develop by @vrishabhsk.
11 months ago
#1
- Keywords has-patch added
#2
@
11 months ago
Hi @akshayrochaniwp 👋🏽
- I have raised a PR for fixing this issue : https://github.com/WordPress/wordpress-develop/pull/8598
Let me know your thoughts on this. Thanks
@vrishabhsk commented on PR #8598:
11 months ago
#3
akshay-r-eq commented on PR #8598:
11 months ago
#4
Hello @Vrishabhsk
Thanks for providing the fix and the WP Playground instance!
I have tested it, and it successfully resolves the issue. Looks good to me! 👍
akshay-r-eq commented on PR #8598:
11 months ago
#5
Hello @Vrishabhsk
Thanks for providing the fix and the WP Playground instance!
I have tested it, and it successfully resolves the issue. Looks good to me! 👍
akshay-r-eq commented on PR #8598:
11 months ago
#6
Hello @Vrishabhsk
Please ignore the previous message, that was added from the wrong GitHub account.
Thanks for providing the fix and the WP Playground instance!
I have tested it, and it successfully resolves the issue. Looks good to me! 👍
akshay-r-eq commented on PR #8598:
11 months ago
#7
Hello @Vrishabhsk
Please ignore the previous message, that was added from the wrong GitHub account.
Thanks for providing the fix and the WP Playground instance!
I have tested it, and it successfully resolves the issue. Looks good to me! 👍
@akshayrochaniwp commented on PR #8598:
11 months ago
#8
Hello @Vrishabhsk
Please ignore the previous message, that was added from the wrong GitHub account.
Thanks for providing the fix and the WP Playground instance!
I have tested it, and it successfully resolves the issue. Looks good to me! 👍
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
4 months ago
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
3 months ago
#12
@
3 months ago
- Milestone changed from Awaiting Review to 7.0
- Owner set to joedolson
- Status changed from new to accepted
- Version set to 4.9
Milestoning for 7.0. I'm setting the version as 4.9, which is when CodeMirror was introduced, although in fact this could have been introduced at some intermediary stage.
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
6 weeks ago
#14
@
5 weeks ago
Going to wait on the updates in #48456 being committed. Have verified that this issue still exists with the updated version of CodeMirror, but I think it will be better to update this patch after the commit.
#15
@
5 weeks ago
It was mentioned in Slack that PR #8598 is adding a surprisingly large amount of code for something which seems like it should be a simple bug fix.
I noticed that the code for handling other languages (HTML, CSS, JavaScript) usually checks whether the key pressed was an alphabetic key using the isAlphaKey variable (sometimes other keys are checked too). But the code for handling PHP does not do this. Wouldn't it be best to just have the PHP-specific code check isAlphaKey too?
Fixed autocomplete dropdown navigation for PHP files :
Trac ticket: https://core.trac.wordpress.org/ticket/63161