WordPress.org
Get WordPress

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#63177 closed defect (bug) (fixed)

Document global $wp_db_version in wp-admin/network/upgrade.php file.

Reported by: upadalavipul's profile upadalavipul Owned by: audrasjb's profile audrasjb
Milestone: 6.9 Priority: low
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: docs, multisite, coding-standards Cc:

Description

I have reviewed the below file code and found that we are using a global $wp_db_version variable. but they do not mention it in the function comment. So I think we need to improve the function comment code.

Files:

trunk/wp-admin/network/upgrade.php

Attachments (1)

63177.diff​ (940 bytes) - added by upadalavipul 4 months ago.
patch Added.

Download all attachments as: .zip

Change History (4)

@upadalavipul
4 months ago

patch Added.

#1 @audrasjb
4 months ago

  • Focuses multisite added
  • Keywords has-patch added
  • Owner set to audrasjb
  • Priority changed from normal to low
  • Status changed from new to accepted
  • Version trunk deleted

Thanks for the ticket and patch, self assigning.

Please note that the patch file wasn't generated against /wordpress-develop but /wp-admin. No issue for this one small patch but for a complex one, it would make it more difficult to apply the patch locally.

#2 @audrasjb
4 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Committed in https://core.trac.wordpress.org/changeset/60095

#3 @audrasjb
4 months ago

  • Milestone changed from Awaiting Review to 6.9
Note: See TracTickets for help on using tickets.