WordPress.org
Get WordPress

Make WordPress Core

Opened 9 months ago

Last modified 9 months ago

#63353 new defect (bug)

Invalid type false for permalink_structure property

Reported by: kkmuffme's profile kkmuffme Owned by:
Milestone: Awaiting Review Priority: normal
Severity: trivial Version:
Component: Rewrite Rules Keywords: has-patch
Focuses: Cc:

Description (last modified by sabernhardt)

​class-wp-rewrite.php, line 1923

If the option is not set (e.g. when installing WP), get_option returns false, which will subsequently pass false to substr/str_ends_with which is invalid
(if strict_type were used, would be a fatal TypeError)

Change History (3)

This ticket was mentioned in ​PR #8742 on ​WordPress/wordpress-develop by ​@kkmuffme.
9 months ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/63353

#2 @sabernhardt
9 months ago

  • Description modified (diff)

​@ankitmaru commented on ​PR #8742:
9 months ago #3

Hi @kkmuffme
I tested it and it seems to be working fine.
This looks like a good solution.

Thank you for your fix.

Note: See TracTickets for help on using tickets.