#63787 closed defect (bug) (fixed)
Fix typo: “such as; Performance” → “such as performance”
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.9 | Priority: | normal |
| Severity: | normal | Version: | 6.1 |
| Component: | Site Health | Keywords: | has-patch commit |
| Focuses: | administration, ui-copy | Cc: |
Description
This fixes a typo on the site health page on recommended improvement section
Attachments (4)
Change History (16)
#2
@
6 months ago
- Keywords needs-refresh removed
Nice catch. We don't need needs-refresh tag. This tag is for refreshing dormant patch, usually months or years old with no movement, and no need for testing.
This ticket was mentioned in PR #9385 on WordPress/wordpress-develop by @naveendwivedi.
6 months ago
#3
Fix: Typo error “such as; Performance” → “such as performance” - see #63787
Trac ticket: https://core.trac.wordpress.org/ticket/63787
#4
@
6 months ago
- Component changed from Administration to Site Health
- Focuses administration ui-copy added
- Milestone changed from Awaiting Review to 6.9
- Version changed from trunk to 6.1
[53950] added the message.
I would also like to split the description into two sentences:
Recommended items are considered beneficial to your site, although not as important to prioritize as a critical issue. They may include improvements to things such as performance, user experience, and more.
#5
@
6 months ago
Thank you for the feedback!
Updated patch to include the revised description suggested by @sabernhardt, in addition to the original typo fix.
Attached latest patch file - 63787-typo-fix.patch
#6
@
6 months ago
I think the last sentence can be further simplified:
They may include improvements to things such as performance and user experience.
The "such as" makes the "and more" redundant.
But since things come better in threes, how about adding "security" since this is one of the common categories:
They may include improvements to things such as security, performance, and user experience.
#7
@
6 months ago
That's a good suggestion to include security.
What if we replace 'things' with 'areas'?
"They may include improvements in areas such as security, performance, and user experience."
#10
@
6 months ago
- Keywords commit added
- Owner set to westonruter
- Status changed from new to accepted
#12
@
5 months ago
In looking at the description for critical issues, I found it was missing an apostrophe in "sites". I also broke up the compound sentence into two sentences, as was done for the recommended improvements description.
@aarti1318 Thank you for opening the ticket and for your first contribution.
A couple tips: When uploading patches to Trac, it's best if each successive patch contains the entire set of changes being proposed for commit. Otherwise, applying the patches requires multiple calls to apply the patch files. But even better is to open a pull request on GitHub with the changes, as @naveendwivedi did in <https://github.com/WordPress/wordpress-develop/pull/9385>. This not only avoids the headache of attaching patch files to Trac, but it also runs all the automated tests to ensure that coding standards are adhered to and that tests still pass.
Thanks again!
This patch fixes a minor typo on the site health screen. Let me know if any changes are needed. Thanks!