WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#6386 closed defect (bug) (fixed)

Add Media dialogs too big on 800×600

Reported by: JeremyVisser Owned by: andy
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.5
Component: Media Keywords: needs-patch
Focuses: Cc:

Description

If you change your screen resolution (like Spencer) or resize your browser (like I do often) to 800×600, you'll find that the Add Media dialogs are too big to fit.

Spencer has uploaded a screenshot of this here: http://www.vindictivebastard.com/images/image-uploadss.jpg

This comes from lines 170-173 of wp-admin/includes/media.php (rev 7517). If you change the height=500 in those lines to height=400, it works much better on 800×600.

I've attached a patch to change the heights to 400, but I'm not sure if it's the right way to go about it. A better solution would be to dynamically change the height with JavaScript depending on what it detects your browser size as so it can accommodate automagically, but I don't understand any of this, so I can't really do it myself.

Attachments (1)

media.php.diff (1.8 KB) - added by JeremyVisser 7 years ago.

Download all attachments as: .zip

Change History (6)

@JeremyVisser7 years ago

comment:1 @JeremyVisser7 years ago

  • Keywords has-patch 2nd-opinion added

comment:2 @markjaquith7 years ago

Benefit of browser window size detection: the modal window can be bigger for people with more real estate.

comment:3 @ryan6 years ago

  • Component changed from Administration to Media

comment:4 @Denis-de-Bernardy6 years ago

  • Keywords needs-patch added; has-patch 2nd-opinion removed

+1 for dynamic

patch is broken, too.

comment:5 @azaozz6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Been fixed for a long time.

Note: See TracTickets for help on using tickets.