wp_die() status code Network and Sites component updates (parent ticket: #64009)

[callumbw95]

If you have come here directly, please refer back to the parent ticket here: #64009

This ticket is regarding the wp_die() function calls within the Media component and will cover the following locations. Please note I was originally linking each of the line numbers, but there are too many for me to submit with this ticket, so I have linked each unique file instead:

Filepath	Line Number	Context	Status Code	New Code	Code Meaning
​src/wp-admin/network/sites.php	88	REQUEST: invalid params	500	400	Bad Request
src/wp-admin/network/sites.php	104	REQUEST: invalid params	500	400	Bad Request
src/wp-admin/network/sites.php	252	User Permissions: does not have access	500	403	Forbidden
​src/wp-admin/network/themes.php	14	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/network/themes.php	102	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/network/themes.php	240	User Permissions: does not have access	500	403	Forbidden
​src/wp-admin/network/site-new.php	17	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/network/site-new.php	40	POST: Missing params	500	400	Bad Request
src/wp-admin/network/site-new.php	56	POST: Invalid Params	500	400	Bad Request
src/wp-admin/network/site-new.php	87	POST: Missing params	500	400	Bad Request
src/wp-admin/network/site-new.php	91	POST: Missing params	500	400	Bad Request
src/wp-admin/network/site-new.php	95	POST: Missing params	500	400	Bad Request
src/wp-admin/network/site-new.php	100	POST: Missing params	500	400	Bad Request
src/wp-admin/network/site-new.php	125	POST: User creation conflict	500	409	Conflict
​src/wp-admin/network/users.php	84	Error: selected user cannot be modified (SA)	500	403	Forbidden
​src/wp-admin/network/site-settings.php	14	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/network/site-settings.php	23	REQUEST: invalid params	500	400	Bad Request
src/wp-admin/network/site-settings.php	28	Missing: site	500	404	Not Found
​src/wp-admin/network/user-new.php	14	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/network/user-new.php	41	POST: Missing params	500	400	Bad Request
​src/wp-admin/network/site-info.php	14	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/network/site-info.php	23	REQUEST: invalid params	500	400	Bad Request
src/wp-admin/network/site-info.php	28	Missing: site	500	404	Not Found
​src/wp-admin/network/site-themes.php	14	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/network/site-themes.php	46	REQUEST: invalid params	500	400	Bad Request
src/wp-admin/network/site-themes.php	53	Missing: site	500	404	Not Found
​src/wp-admin/network/site-users.php	41	REQUEST: invalid params	500	400	Bad Request
src/wp-admin/network/site-users.php	46	Missing: site	500	404	Not Found
​src/wp-admin/network/admin.php	17	Error: Multisite is not enabled	500	409	Conflict
​src/wp-admin/includes/ms.php	891	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/includes/ms.php	901	Error: selected user cannot be deleted (SA)	500	403	Forbidden
​src/wp-admin/includes/ms-deprecated.php	33	Filesystem: no space left	500	507	Insufficient Storage
​src/wp-admin/ms-delete-site.php	13	Support: Multisite is not enabled	500	409	Conflict
src/wp-admin/ms-delete-site.php	17	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/ms-delete-site.php	23	Success: Site deleted	500	200	OK
src/wp-admin/ms-delete-site.php	31	Error: Stale link	500	410	Gone
​src/wp-admin/network.php || 19	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/network.php	29	Error: invalid params	500	400	Bad Request
src/wp-admin/network.php	41	Error: invalid params	500	400	Bad Request
​src/wp-admin/my-sites.php	13	Support: Multisite is not enabled	500	409	Conflict
src/wp-admin/my-sites.php	17	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/my-sites.php	33	Missing: site	500	404	Not Found

I have also put in a PR with these changes so it’s easier to see where in the code each lies, and the surrounding code.

There are however the following function calls I have not touched as I felt they were already valid with their current status code:

Filepath	Line Number	Status Code
​src/wp-admin/includes/ms.php	49	500
src/wp-admin/includes/ms.php	575	403
src/wp-admin/includes/ms.php	605	403
src/wp-admin/includes/ms.php	1186	403
​src/wp-admin/network/index.php	17	403
​src/wp-admin/network/settings.php	17	403
​src/wp-admin/network/site-info.php	32	403
​src/wp-admin/network/site-new.php	130	500
src/wp-admin/network/site-new.php	165	500
​src/wp-admin/network/site-settings.php	32	403
​src/wp-admin/network/site-themes.php	57	403
​src/wp-admin/network/site-users.php	14	403
src/wp-admin/network/site-users.php	50	403
src/wp-admin/network/site-users.php	120	403
src/wp-admin/network/site-users.php	146	403
src/wp-admin/network/site-users.php	157	403
​src/wp-admin/network/sites.php	14	403
src/wp-admin/network/sites.php	151	402
src/wp-admin/network/sites.php	175	402
​src/wp-admin/network/upgrade.php	39	403
src/wp-admin/network/upgrade.php	96	500
​src/wp-admin/network/user-new.php	37	403
​src/wp-admin/network/users.php	14	403
src/wp-admin/network/users.php	24	403
src/wp-admin/network/users.php	51	403
src/wp-admin/network/users.php	65	403
src/wp-admin/network/users.php	160	403
​src/wp-includes/ms-deprecated.php	277	400
src/wp-includes/ms-deprecated.php	296	400
​src/wp-includes/ms-functions.php	2240	500
​src/wp-includes/ms-load.php	99	410
src/wp-includes/ms-load.php	108	500
src/wp-includes/ms-load.php	122	410
src/wp-includes/ms-load.php	511	500

…s related to the media component

Trac ticket: #64021