WordPress.org
Get WordPress

Make WordPress Core

Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#64100 closed defect (bug) (fixed)

README file should recommend creating a fork

Reported by: pbearne Owned by: desrosj
Priority: normal Milestone: 6.9
Component: General Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

The current README doesn't suggest that wordpress-develop repro is forked before cloned to local install

Change History (13)

This ticket was mentioned in ​PR #10286 on ​WordPress/wordpress-develop by ​@pbearne.
11 months ago #1

  • Keywords has-patch added

#2 @desrosj
11 months ago

  • Milestone Awaiting Review → 6.9
  • Owner changed from pbearne to desrosj
  • Status assigned → reviewing

#3 @desrosj
11 months ago

  • Summary we should fork the repo before cloning → README file should recommend creating a fork

#4 @desrosj
10 months ago

  • Keywords changes-requested added

#5 @wildworks
10 months ago

  • Keywords commit added; changes-requested removed

Based on the attached pull request, it appears that the commit is ready.

#6 @desrosj
10 months ago

Added a few more small change suggestions to the PR. I will commit tomorrow if there are no objections.

#7 @pbearne
10 months ago

merged suggestions

This ticket was mentioned in ​Slack in #core by welcher. ​View the logs.
10 months ago

​@peterwilsoncc commented on ​PR #10286:
10 months ago #9

This looks good to me for the purpose of clarifying to create a fork.

While editing the file, should the code spaces reference be removed as they haven't worked for a while. See https://core.trac.wordpress.org/ticket/57896

https://github.com/user-attachments/assets/e5341263-319d-4a8d-a164-534955c96459

​@desrosj commented on ​PR #10286:
10 months ago #10

While editing the file, should the code spaces reference be removed as they haven't worked for a while. See https://core.trac.wordpress.org/ticket/57896

That makes sense, I think. It would be great to get that fixed, but preventing frustration for anyone attempting to use that as a means to contribute is probably best in the mean time.

#11 @desrosj
10 months ago

  • Component Build/Test Tools → General

#12 @desrosj
10 months ago

  • Resolution → fixed
  • Status reviewing → closed

In 61202:

General: Clarify that contributors should fork wordpress-develop.

Because WordPress/wordpress-develop is a mirror, the only way to contribute to WordPress on GitHub is by forking the repository (even when a contributor has write access as a Core Committer). This updates the “Getting Started” section to make this more clear.

The section about how to contribute using GitHub Codespaces is also being removed since this has been broken for some time (see #57896). This section can be reintroduced once the underlying tooling is fixed.

Props pbearne, desrosj, westonruter, wildworks, peterwilsoncc.
Fixes #64100. See #57896.

#13 @desrosj
10 months ago

In 61203:

General: Remove redundant step.

The cd wordpress-develop step is now mentioned for both approaches for creating a fork and cloning listed above.

Follow up to [61202].

Props pbearne, desrosj, westonruter, wildworks, peterwilsoncc.
See #64100.

Note: See TracTickets for help on using tickets.