Undefined variable $comments_count

[zagna]

In function wp_dashboard_recent_comments if the foreach always goes to the continue, $comments_count is never set and gives a warning.

<?php
add_filter( 'register_post_post_type_args', function($args, $post_type) {
        $args['map_meta_cap'] = false;
        return $args;
}, 10, 2);

Adding this to twentytwentyfive functions.php for a quick reproduction on a fresh 6.9b4

[westonruter]

This issue is flagged by PhpStorm's static analysis as well, see phpstorm-static-anslysis.png​.

Here is the problematic code: ​https://github.com/WordPress/wordpress-develop/blob/328ab83beb153ffa6d5378b26bb4ef2ceee49c47/src/wp-admin/includes/dashboard.php#L1077-L1103

It seems a very simply fix, to just add before the do/while loop:

<?php
$comments_count = 0;

This issue appears to have been introduced in r60643 to fix #56499.

Trac ticket: https://core.trac.wordpress.org/ticket/64223

[westonruter]

This issue is also detected by PHPStan: phpstan-static-analysis.png​.

See #61175. /cc @justlevine

[westonruter]

In 61192:

Coding Standards: Initialize $comments_count before loop in case not set during initial iteration.

Follow-up to [60643].

Props westonruter, mindctrl.
See #56499.
Fixes #64223.