Opened 5 months ago
Closed 4 weeks ago
#64224 closed task (blessed) (fixed)
Docblock improvements for 7.0
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 7.0 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | General | Keywords: | has-patch |
| Focuses: | coding-standards | Cc: |
Description
Previously:
Change History (138)
#1
@
5 months ago
- Summary changed from Dockblock improvements for 7.0 to Docblock improvements for 7.0
This ticket was mentioned in PR #9286 on WordPress/wordpress-develop by @rutujaparamane2004.
5 months ago
#4
- Keywords has-patch added
Trac ticket: https://core.trac.wordpress.org/ticket/64224
@SergeyBiryukov commented on PR #9286:
5 months ago
#5
Thanks for the PR! Merged in r61275.
This ticket was mentioned in PR #10562 on WordPress/wordpress-develop by @huzaifaalmesbah.
5 months ago
#11
### Description
This PR adds missing variable names to @param tags in Twenty Eleven, Twenty Ten, and Twenty Twenty themes.
### Changes
Twenty Eleven: category.php, functions.php
Twenty Ten: loop-attachment.php, author.php
Twenty Twenty: functions.php, inc/template-tags.php, template-parts/entry-header.php, template-parts/content-cover.php
### Testing Instructions
- Navigate to the affected files.
- Verify that the docblocks for the mentioned filters now include the variable names in the @param tags.
- Ensure no PHP errors or warnings are generated.
@noruzzaman commented on PR #10562:
5 months ago
#17
I have followed the testing instructions for Twenty Eleven, Twenty Ten, and Twenty Twenty.
The updated docblocks now include the missing parameter names ($html, $width, $height, $size, $elements, $post_types, $show_categories), and I’m not seeing any PHP warnings or notices.
This looks good to me and improves the clarity of the bundled theme docs.
This ticket was mentioned in PR #10569 on WordPress/wordpress-develop by @huzaifaalmesbah.
5 months ago
#18
## Description
Improves inline documentation for WP_Comments_List_Table in wp-admin/includes/class-wp-comments-list-table.php to align with WordPress coding standards.
## Changes
- Added missing summary descriptions.
- Improved specificity of
@returnand@paramtags.
## Testing Instructions
- Inspect
src/wp-admin/includes/class-wp-comments-list-table.php. - Verify docblocks follow standards.
@SergeyBiryukov commented on PR #10562:
5 months ago
#19
@noruzzaman commented on PR #10569:
5 months ago
#20
Thanks for the update @huzaifaalmesbah! I have gone through the changes, and everything looks cleaner and much easier to follow now. The added descriptions and improved @return / @param details definitely make the docblocks more useful.
Nice improvement overall.
@huzaifaalmesbah commented on PR #10569:
5 months ago
#21
@westonruter Thank you for your review and suggestions. I’ve applied the changes you recommended.
This ticket was mentioned in PR #10570 on WordPress/wordpress-develop by @rejaulalomkhan.
5 months ago
#22
## Description
This PR improves inline documentation in wp-admin files by adding missing parameter descriptions to function docblocks.
## Changes
- ✅ Added proper
@paramdescriptions for functions missing them - ✅ Added complete docblock for
wp_load_press_this()function - ✅ Enhanced function summary for
wp_nav_menu_max_depth() - ✅ All changes follow WordPress PHP Documentation Standards
## Files Modified
wp-admin/install.phpwp-admin/nav-menus.phpwp-admin/update-core.phpwp-admin/includes/ajax-actions.phpwp-admin/includes/class-wp-importer.php
## Testing
- [x] No functional changes, documentation only
- [x] All parameter descriptions are accurate and follow WP standards
@rejaulalomkhan commented on PR #10570:
3 months ago
#38
Hi @westonruter, I've made the changes you suggested. Thanks for your help!
@westonruter commented on PR #10570:
3 months ago
#41
Committed in r61520
@westonruter commented on PR #10569:
3 months ago
#43
This ticket was mentioned in PR #10788 on WordPress/wordpress-develop by @huzaifaalmesbah.
3 months ago
#44
Ticket: https://core.trac.wordpress.org/ticket/64224
# Changes
-
class-wp-importer.php: Added missing file header. -
media.php: Fixed missing@param/@globaldescriptions and@returnformat. -
class-wp-list-table.php: Added missing summaries and fixed formatting. -
user.php: Added missing@param/@globaldescriptions.
This ticket was mentioned in PR #10800 on WordPress/wordpress-develop by @johnbillion.
3 months ago
#49
Trac ticket: Core-64224.
This ticket was mentioned in PR #10802 on WordPress/wordpress-develop by @huzaifaalmesbah.
3 months ago
#50
This PR replaces an @see tag with @link in WP_REST_Global_Styles_Controller to align with WordPress PHP Inline Documentation Standards.
Tickets:
Trac Ticket #64224
Originally discussed in Gutenberg PR #74961
Changes:
Replaced @see with @link for the HTML specification URL.
This ticket was mentioned in PR #10804 on WordPress/wordpress-develop by @huzaifaalmesbah.
3 months ago
#52
Trac Ticket: https://core.trac.wordpress.org/ticket/64224
## Why this change?
This change aligns the codebase with the WordPress PHP Documentation Standards, which clearly distinguish between the intended usage of the @see and @link tags:
@seeis meant for referencing internal structural elements of the WordPress codebase, such as classes, functions, methods, or hooks.@linkis meant for referencing external resources, including URLs, specifications, and tickets hosted outside the codebase.
Currently, there are several instances in WordPress core where @see is incorrectly used to reference:
- GitHub URLs
- Trac tickets
- External specifications (e.g. WHATWG specs)
This PR corrects those cases by replacing @see with @link where the reference points to an external resource.
## When to use @link
- External URLs
Always use
@linkwhen referencing an external URL Example:@link https://html.spec.whatwg.org
- External resources
Use
@linkfor documentation, specifications, or tickets that live outside the WordPress codebase
## Contrast with @see
- Internal structure references
Use
@seewhen referring to:- Functions (e.g.
@see wp_remote_get()) - Classes (e.g.
@see WP_Query) - Methods or hooks defined within WordPress core
- Functions (e.g.
## Detailed changes
This PR applies targeted fixes across 15 specific files in src/wp-admin and src/wp-includes, replacing incorrect @see tags with @link where appropriate.
### src/wp-admin
edit-form-blocks.phpsite-editor.php
### src/wp-includes
html-api/class-wp-html-active-formatting-elements.phphtml-api/class-wp-html-doctype-info.phphtml-api/class-wp-html-tag-processor.phphtml-api/class-wp-html-decoder.phpclass-wp-url-pattern-prefixer.phpnav-menu-template.phppluggable.phpmedia.phprest-api/endpoints/class-wp-rest-controller.phprest-api/endpoints/class-wp-rest-templates-controller.phpscript-loader.phpspeculative-loading.phpdeprecated.php
@noruzzaman commented on PR #10804:
3 months ago
#53
@huzaifaalmesbah Thanks for working on this cleanup!
The conversion from @see to @link for external URLs is correct and follows the WordPress documentation standards. However, for better consistency within this PR, I suggest adding a brief description after each @link URL, similar to what was done in src/wp-includes/html-api/class-wp-html-decoder.php
For example: * @link [URL] [Brief Description]
This would make the documentation more descriptive and maintain a uniform style across all the modified files in this PR.
@SergeyBiryukov commented on PR #10788:
3 months ago
#54
@johnbillion commented on PR #10800:
3 months ago
#56
@SergeyBiryukov commented on PR #10802:
3 months ago
#58
Thanks for the PR! Merged in r61557.
@westonruter commented on PR #10804:
3 months ago
#59
I had wondered about this, but @see seems to be OK for _either_ structural elements _or_ a URI. See https://docs.phpdoc.org/guide/references/phpdoc/tags/see.html (pun intended)
@huzaifaalmesbah commented on PR #10804:
3 months ago
#60
Thanks for pointing this out @westonruter !
You’re right. phpDocumentor does allow using @see with a URI as well.
However, according to the [WordPress PHP Documentation Standards](https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#1-functions-class-methods
) for DocBlocks:
👉 URLs should be added with the @link tag.
Specifically, the handbook states:
*@link: URL that provides more information. This should never be used to reference another function, hook, class, or method — see @see.*
And:
*@see: Reference to a function/method/class that the function/method relies on.*
So, while generic phpDocumentor allows linking URLs with @see, WordPress core’s own standard distinguishes them semantically — and this PR is aligning core with that documented WordPress standard for consistency.
Otherwise… I guess we might need to update the WordPress PHP Documentation Standards too 😄
This ticket was mentioned in PR #10841 on WordPress/wordpress-develop by @noruzzaman.
3 months ago
#64
Trac Ticket: https://core.trac.wordpress.org/ticket/64224
Why this change?
This change adds missing @global documentation tags to functions in
src/wp-includes/meta.php
src/wp-includes/deprecated.php
This aligns the codebase with the WordPress PHP Documentation Standards, ensuring that global variables used within functions are properly documented for better static analysis and code clarity.
Files Changed:
src/wp-includes/meta.php
src/wp-includes/deprecated.php
This ticket was mentioned in PR #10863 on WordPress/wordpress-develop by @huzaifaalmesbah.
2 months ago
#67
This PR adds missing descriptions to @return tags in various files within src/wp-admin/includes and src/wp-includes to ensure compliance with WordPress Coding Standards.
This ticket was mentioned in PR #10864 on WordPress/wordpress-develop by @noruzzaman.
2 months ago
#68
Trac Ticket: https://core.trac.wordpress.org/ticket/64224
Why this change?
This change adds missing @global documentation tags to functions in
src/wp-admin/includes/misc.php
src/wp-admin/includes/template.php
src/wp-admin/install.php
This aligns the codebase with the WordPress PHP Documentation Standards, ensuring that global variables used within functions are properly documented for better static analysis and code clarity.
Files Changed:
src/wp-admin/includes/misc.php
src/wp-admin/includes/template.php
src/wp-admin/install.php
@huzaifaalmesbah commented on PR #10864:
2 months ago
#69
@noruzzamans Looks good. i have suggest minor changes.
@shailu25 commented on PR #10864:
2 months ago
#70
Please exclude the bundled theme changes, as they are already being tracked in a separate ticket. #58715
@mukesh27 commented on PR #10863:
2 months ago
#71
This all not blocker but nice to have. Thanks @huzaifaalmesbah for the PR!
@westonruter for you if you want to commit or have any suggestions.
@westonruter commented on PR #10863:
2 months ago
#72
In keeping also with Core-64238, in 7a409a2 I've had Gemini help me flesh out the return types to be more specific than just simply array.
@noruzzaman commented on PR #10864:
2 months ago
#73
@noruzzamans Please exclude the bundled theme changes, as they are already being tracked in a separate ticket. #58715
@shail-mehta @sabernhardt Thanks. I have reverted the bundled theme changes. Actually, I didn’t know it had a separate ticket.
@westonruter commented on PR #10863:
2 months ago
#77
Committed in r61594 (45a4e0f)
@shailu25 commented on PR #10841:
2 months ago
#79
@noruzzamans Could you please resolve conflicts?
@huzaifaalmesbah commented on PR #10841:
2 months ago
#80
It looks like this PR may already have been committed:
@noruzzaman commented on PR #10841:
2 months ago
#81
@shail-mehta @westonruter @mukeshpanchal27 @huzaifaalmesbah Thanks for review. I have updated all changes. if need any changes please let me know. Thanks
@noruzzaman commented on PR #10841:
2 months ago
#83
Let’s update the PR title and description, as they’re outdated now.
@mukeshpanchal27 Thanks. I have updated the title and description based on your suggestion.
@westonruter commented on PR #10841:
2 months ago
#85
Committed in r61604 (4cad33a)
This ticket was mentioned in PR #10907 on WordPress/wordpress-develop by @dmsnell.
2 months ago
#86
Replace Closure call syntax ( $fn )( ...$args ) with equivalent call_user_func( $fn, ...$args ).
This prevents an issue with the WordPress documentation parser:
Parse Error: Syntax error, unexpected '('
@jonsurrell commented on PR #10907:
2 months ago
#88
Merged in r61624.
This ticket was mentioned in Slack in #core by juanmaguitar. View the logs.
2 months ago
@westonruter commented on PR #10864:
2 months ago
#91
Committed in r61638 (039e100)
This ticket was mentioned in PR #10931 on WordPress/wordpress-develop by @noruzzaman.
2 months ago
#92
Trac Ticket: https://core.trac.wordpress.org/ticket/64224
Why this change?
This change adds missing @global documentation tags.
This aligns the codebase with the WordPress PHP Documentation Standards, ensuring that global variables used within functions are properly documented for better static analysis and code clarity.
@westonruter commented on PR #10931:
2 months ago
#93
Note: There's no real need to merge trunk back into a branch unless it's likely there will be a merge conflict or a breakage. The committer will ultimately ensure the latest from trunk is merged at the time of commit to SVN.
@noruzzaman commented on PR #10931:
2 months ago
#94
Some function docblocks still have scope improvements on
class-wp-links-list-table.php: L79 L86 L145
Although these are not related to globals or parameters, they are missing proper summaries and return documentation. Could you please review and update these as well?
Thanks @huzaifaalmesbah. I have updated and improved the missing docs.
@noruzzaman commented on PR #10931:
2 months ago
#95
Note: There's no real need to merge
trunkback into a branch unless it's likely there will be a merge conflict or a breakage. The committer will ultimately ensure the latest fromtrunkis merged at the time of commit to SVN.
Thanks. I have resolved all issues.
@westonruter commented on PR #10931:
2 months ago
#97
Committed in r61657 (1a7da55fd14f22d9d5028ff3a3e92807e6c63eea).
This ticket was mentioned in PR #10963 on WordPress/wordpress-develop by @noruzzaman.
2 months ago
#98
Trac Ticket: https://core.trac.wordpress.org/ticket/64224
Why this change?
This change adds missing @global documentation tags.
This aligns the codebase with the WordPress PHP Documentation Standards, ensuring that global variables used within functions are properly documented for better static analysis and code clarity.
This ticket was mentioned in PR #10989 on WordPress/wordpress-develop by @huzaifaalmesbah.
2 months ago
#101
This patch improves the PHPDoc docblocks in WP_List_Table and WP_Plugins_List_Table for accuracy, completeness, and consistency with WordPress core documentation standards.
@westonruter commented on PR #10963:
8 weeks ago
#103
Committed in r61717 (dc64903)
This ticket was mentioned in PR #11022 on WordPress/wordpress-develop by @dmsnell.
8 weeks ago
#105
Trac ticket: Core-64224
Resolves: https://github.com/WordPress/Documentation-Issue-Tracker/issues/1849
This was previosly listed as defaulting to false when in fact it defaults to true.
As this is a documentation-only change it should include no code or functionality changes.
This ticket was mentioned in PR #11023 on WordPress/wordpress-develop by @noruzzaman.
8 weeks ago
#106
Trac Ticket: https://core.trac.wordpress.org/ticket/64224
Why this change?
This aligns the codebase with the WordPress PHP Documentation Standards, ensuring that global variables used within functions are properly documented for better static analysis and code clarity.
Missing Tags: Added missing @global, @param, and @return descriptions.
Method Summaries: Added summaries for several methods in both list table classes that were previously undocumented.
Property Docs: Added DocBlocks for class properties ($order, $orderby, etc.).
@dmsnell commented on PR #11022:
8 weeks ago
#109
just to update those tagging on to this ticket now; it would have been merged yesterday except for the flakey end-to-end tests which are failing. as soon as those pass and I’m around to do it, I will merge.
This ticket was mentioned in PR #11040 on WordPress/wordpress-develop by @Soean.
8 weeks ago
#110
Changed the parameter name in the docblock from $_request to $request in the get_items_permissions_check method of WP_REST_Icons_Controller to match the actual parameter name.
Trac ticket: https://core.trac.wordpress.org/ticket/64224
@dmsnell commented on PR #11022:
8 weeks ago
#112
@SergeyBiryukov commented on PR #11040:
8 weeks ago
#114
Thanks for the PR! Merged in r61739.
This ticket was mentioned in PR #11076 on WordPress/wordpress-develop by @jonsurrell.
7 weeks ago
#115
WordPress 6.7 introduced many methods to the HTML API. They were intitially stub implementations, but later were fully implemented. The "stub implementation" since annotations incorrectly remained in many cases.
See https://core.trac.wordpress.org/browser/tags/6.7/src/wp-includes/html-api/class-wp-html-processor.php where the "stub implementation" annotations are present on fully implemented methods.
Trac ticket: https://core.trac.wordpress.org/ticket/64224
This ticket was mentioned in PR #11078 on WordPress/wordpress-develop by @jonsurrell.
7 weeks ago
#116
The HTML API relies on many private and internal methods and classes. All of theme appear in the public documentation. This introduces a lot of noise into the documentation that's irrelevant for anyone not working directly on the HTML API itself.
By adding ignore annotations to most of the internal and private methods and classes, the documentation will be much cleaner and more relevant.
See the HTML processor class methods page for example. None of these internal methods should be of interest to folks _using_ the HTML API:
I have kept a few "internal" things documented, like the WP_HTML_Text_Replacement and WP_HTML_Span which are often useful for subclasses working with bookmarks and replacements.
https://github.com/WordPress/wordpress-develop/blob/33ebdd7e1135590e4d1a0beec6a5ecfb7fa2cf6f/src/wp-includes/html-api/class-wp-html-text-replacement.php#L16-L22
https://github.com/WordPress/wordpress-develop/blob/33ebdd7e1135590e4d1a0beec6a5ecfb7fa2cf6f/src/wp-includes/html-api/class-wp-html-span.php#L19-L25
This ticket was mentioned in PR #11087 on WordPress/wordpress-develop by @noruzzaman.
7 weeks ago
#117
Trac Ticket: https://core.trac.wordpress.org/ticket/64224
Why this change?
This aligns the codebase with the WordPress PHP Documentation Standards, ensuring that global variables used within functions are properly documented for better static analysis and code clarity.
Missing Tags: Added missing @global, @param, and @return descriptions.
Method Summaries: Added summaries for several methods in both list table classes that were previously undocumented.
Property Docs: Added DocBlocks for class properties ($order, $orderby, etc.).
@jonsurrell commented on PR #11078:
7 weeks ago
#118
Does the docs generator not ignore
@access privatesymbols?
No, it doesn't seem to. @ignore is used to hide things from public documentation.
@access private seems to add a notice to methods, but not to classes. I've created https://github.com/WordPress/phpdoc-parser/issues/255 for this.
@jonsurrell commented on PR #11076:
7 weeks ago
#120
Merged in r61792.
@jonsurrell commented on PR #11078:
7 weeks ago
#122
Merged in r61793.
This ticket was mentioned in PR #11201 on WordPress/wordpress-develop by @apermo.
6 weeks ago
#123
## Summary
The rest_revision_query filter in WP_REST_Revisions_Controller::get_items() carried a cross-reference comment claiming it was documented in the posts controller:
/** This filter is documented in wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php */
$args = apply_filters( 'rest_revision_query', $args, $request );
That cross-reference is incorrect. The posts controller documents rest_{$this->post_type}_query — a dynamic hook that fires only for post types managed by WP_REST_Posts_Controller. WP_REST_Revisions_Controller extends WP_REST_Controller directly (not the posts controller), so the dynamic hook never fires for revisions. rest_revision_query is a standalone hook and has never had its own PHPDoc block.
## Changes
- Replace the broken cross-reference comment with a proper
@since 4.7.0PHPDoc block forrest_revision_query - Add
@see WP_REST_Posts_Controller::get_items()to theget_items()method docblock to surface the parallel relationship between the two controllers, following the same{@see}pattern used incomment.phpandpost.phpfor related hooks
## Use of AI Tools
Research (architectural investigation, prior-art search across core) and code were produced by Claude Code (claude-sonnet-4-6). The contributor reviewed the findings, steered the documentation approach, and approved the final implementation.
This ticket was mentioned in PR #11202 on WordPress/wordpress-develop by @apermo.
6 weeks ago
#124
## Summary
Fixes 8 broken "This filter/action is documented in …" cross-reference comments where the referenced file path contains a typo or incorrect prefix:
wp-includes/widget.php→wp-includes/widgets.php(missing 's') — 3 xrefsedit-form-blocks.php→wp-admin/edit-form-blocks.php(missing prefix) — 1 xrefwp-admin/post.php→wp-admin/includes/post.php(missingincludes/) — 1 xrefsrc/wp-admin/includes/file.php→wp-admin/includes/file.php(spurioussrc/) — 2 xrefswp-admin/includes/media.php→wp-includes/media.php(wrong path) — 1 xref
Also corrects two hook type labels (filter → action for wp_creating_autosave, action → filter for unzip_file).
For detailed investigation notes, see: https://github.com/apermo/wordpress-develop/milestone/2
## Use of AI Tools
Research (cross-reference audit using custom PHPStan rules and PHP scripts) and code were produced by Claude Code (claude-sonnet-4-6). The contributor reviewed the findings, verified each fix, and approved the final implementation.
This ticket was mentioned in PR #11203 on WordPress/wordpress-develop by @apermo.
6 weeks ago
#125
## Summary
Fixes 17 broken "This filter/action is documented in …" cross-reference comments where the hook was moved to a different file but the cross-reference was not updated:
wp-admin/widgets.php→wp-admin/widgets-form.php(sidebar_admin_setup,delete_widget) — 5 xrefswp-includes/query.php→wp-includes/class-wp-query.php(comment_feed_*filters) — 5 xrefswp-includes/wp-diff.php→wp-includes/class-wp-text-diff-renderer-table.php(process_text_diff_html) — 2 xrefswp-includes/comment-template.php→wp-includes/comment.php(comment_flood_message) — 1 xrefwp-includes/ms-settings.php→wp-includes/ms-load.php(ms_network_not_found) — 1 xrefwp-includes/ms-blogs.php→wp-includes/ms-site.php(delete_blog,deleted_blog) — 2 xrefswp-includes/class-wp-image-editor-imagick.php→wp-includes/class-wp-image-editor-gd.php(image_save_progressive) — 3 xrefs (core only; 3 additional in bundled Gutenberg)wp-includes/class-wp-image-editor.php→wp-includes/media.php(image_editor_output_format) — 1 xref
For detailed investigation notes, see: https://github.com/apermo/wordpress-develop/milestone/2
## Use of AI Tools
Research (cross-reference audit using custom PHPStan rules and PHP scripts) and code were produced by Claude Code (claude-sonnet-4-6). The contributor reviewed the findings, verified each fix, and approved the final implementation.
This ticket was mentioned in PR #11204 on WordPress/wordpress-develop by @apermo.
6 weeks ago
#126
## Summary
Fixes 3 cases where hooks are registered with the wrong function — add_action() used on a filter or add_filter() used on an action. Functionally equivalent (since add_action() calls add_filter() internally), but semantically incorrect.
### add_filter() → add_action() (hook is fired via do_action()):
admin_print_stylesinwp-admin/includes/admin-filters.phplogin_headinwp-includes/default-filters.php
### add_action() → add_filter() (hook is fired via apply_filters()):
use_block_editor_for_post_typeinwp-admin/includes/admin-filters.php
A 4th mismatch (get_block_type_variations using add_action() on a filter) originates in the Gutenberg repo and is tracked separately: https://github.com/WordPress/gutenberg/issues/76296
For detailed investigation notes, see: https://github.com/apermo/wordpress-develop/milestone/4
## Use of AI Tools
Research (systematic cross-referencing of all add_action/add_filter registrations against their do_action/apply_filters call sites) and code were produced by Claude Code (claude-sonnet-4-6). The contributor reviewed the findings, verified each fix, and approved the final implementation.
This ticket was mentioned in PR #11205 on WordPress/wordpress-develop by @apermo.
6 weeks ago
#127
## Summary
Adds 11 missing "This filter/action is documented in …" cross-reference comments for hook calls that have a canonical PHPDoc block elsewhere but were missing the xref:
the_title(×4 inwp-includes/deprecated.php) → canonical PHPDoc inwp-includes/post-template.phplink_category(×1 inwp-includes/deprecated.php) → canonical PHPDoc inwp-includes/bookmark-template.phpenqueue_block_assets(×1 inwp-includes/block-editor.php) → canonical PHPDoc inwp-includes/script-loader.php- Legacy
load-*.phpactions (×5 inwp-admin/admin.php) → canonical PHPDoc forload-{$pagenow}in the same file
For detailed investigation notes, see: https://github.com/apermo/wordpress-develop/milestone/5
## Use of AI Tools
Research (cross-reference audit across all hook call sites in core) and code were produced by Claude Code (claude-sonnet-4-6). The contributor reviewed the findings, verified each fix, and approved the final implementation.
@SergeyBiryukov commented on PR #11203:
6 weeks ago
#129
Thanks for the PR! Merged in r61878.
@SergeyBiryukov commented on PR #11202:
6 weeks ago
#131
Thanks for the PR! Merged in r61946.
@westonruter commented on PR #11205:
5 weeks ago
#133
Committed in r61994 (78ec1ff)
In 61270: