#52628 closed task (blessed) (fixed)
Docblock improvements for WP 5.8
| Reported by: | SergeyBiryukov | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.8 |
| Component: | General | Version: | |
| Severity: | normal | Keywords: | has-patch commit dev-reviewed |
| Cc: | Focuses: | docs |
Attachments (2)
Change History (77)
#14
@
5 years ago
Thanks for the patch, @sabernhardt. I found another instance of $htmlhint being improperly described in another docblock on line 3537 in wp-includes/general-template.php. I'll address that one as well in the commit that follows.
#18
@
5 years ago
[49597] has limited the return type of wp_get_object_terms() to only arrays of type WP_Term. But depending on the fields argument other array types are supported too. For example int[] in case of 'fields' => 'ids'. Same for the filters in the function.
This ticket was mentioned in Slack in #core by peterwilsoncc. View the logs.
5 years ago
#20
@
5 years ago
Added 52628.class-walker-page.diff to fix an incorrect comment from #43522 (r42808).
This ticket was mentioned in PR #1242 on WordPress/wordpress-develop by bahiirwa.
5 years ago
#23
- Keywords has-patch added
This was skipped in the review for https://core.trac.wordpress.org/changeset/48315
A simple typo.
PS: I don't know how to handle this. I have reported this to https://core.trac.wordpress.org/ticket/52628
#24
@
5 years ago
This was skipped in the review for https://core.trac.wordpress.org/changeset/48315
A simple typo. I have made a PR via https://github.com/WordPress/wordpress-develop/pull/1242. I do not know if that's the right space.
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
5 years ago
This ticket was mentioned in Slack in #core by desrosj. View the logs.
5 years ago
#56
@
5 years ago
- Keywords commit dev-feedback added
- Resolution fixed
- Status closed → reopened
Reopening to backport.
#68
@
5 years ago
- Keywords dev-reviewed added; dev-feedback removed
- Resolution → fixed
- Status reopened → closed
All changes have been backported. If more are needed, we can reopen to backport those.
@SergeyBiryukov commented on PR #1242:
11 months ago
#75
Thanks for the PR! This was merged in r53251.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
In 50434: