#51075 closed defect (bug) (fixed)
Update docs for custom logo functions
Reported by: | sabernhardt | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.5.1 | Priority: | normal |
Severity: | normal | Version: | 5.6 |
Component: | Themes | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
In #37011, I missed that the get_custom_logo()
function summary and @since
note were not updated when removing the link became optional.
The summary also would need to be updated for the_custom_logo
.
Attachments (1)
Change History (8)
#2
@
4 years ago
- Component changed from General to Themes
- Milestone changed from Awaiting Review to 5.5.1
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#5
follow-up:
↓ 6
@
4 years ago
I was answering a forum question about this, and noticed that the add_theme_support
function does not mention the unlink-homepage-logo
feature.
#6
in reply to:
↑ 5
@
4 years ago
Replying to joyously:
I was answering a forum question about this, and noticed that the
add_theme_support
function does not mention theunlink-homepage-logo
feature.
Thanks for flagging that! unlink-homepage-logo
is not a feature by itself, it's one of the values for the custom-logo
feature, same as width
, height
, flex-width
, flex-height
, and header-text
.
It was mentioned in a @since
note for 5.5.0, see [48749]:
@since 5.5.0 The `custom-logo` feature now also accepts 'unlink-homepage-logo'.
That said, the documentation for the Custom Logo feature did indeed miss it. I've updated that section to include unlink-homepage-logo
.
51075.patch is a first draft. I'm sure the wording can be clearer, though.