WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#51075 closed defect (bug) (fixed)

Update docs for custom logo functions

Reported by: sabernhardt Owned by: SergeyBiryukov
Milestone: 5.5.1 Priority: normal
Severity: normal Version: 5.6
Component: Themes Keywords: has-patch
Focuses: docs Cc:

Description

In #37011, I missed that the get_custom_logo() function summary and @since note were not updated when removing the link became optional.

The summary also would need to be updated for the_custom_logo.

Attachments (1)

51075.patch​ (985 bytes) - added by sabernhardt 6 months ago.

Download all attachments as: .zip

Change History (5)

@sabernhardt
6 months ago

#1 @sabernhardt
6 months ago

  • Keywords has-patch added; needs-patch removed

51075.patch​ is a first draft. I'm sure the wording can be clearer, though.

#2 @SergeyBiryukov
6 months ago

  • Component changed from General to Themes
  • Milestone changed from Awaiting Review to 5.5.1
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48832:

Docs: Update documentation for get_custom_logo() and the_custom_logo() to mention the unlink-homepage-logo theme feature.

Follow-up to [48039], [48283], [48749], [48757], [48758].

Props sabernhardt.
Fixes #51075.

#4 @SergeyBiryukov
6 months ago

In 48833:

Docs: Update documentation for get_custom_logo() and the_custom_logo() to mention the unlink-homepage-logo theme feature.

Follow-up to [48039], [48283], [48749], [48757], [48758].

Props sabernhardt.
Merges [48832] to the 5.5 branch.
Fixes #51075.

Note: See TracTickets for help on using tickets.