Make WordPress Core

Opened 8 weeks ago

Closed 7 weeks ago

#64333 closed defect (bug) (fixed)

I18N: border.radiusSizes key is missing in theme-i18n.json

Reported by: wildworks's profile wildworks Owned by: wildworks's profile wildworks
Milestone: 6.9.1 Priority: normal
Severity: normal Version: 6.9
Component: I18N Keywords: has-patch commit fixed-major dev-reviewed
Focuses: Cc:

Description (last modified by wildworks)

Related to #63799

Originally reported at https://github.com/WordPress/gutenberg/issues/73688 by @twvania

For preset names to be translatable, the preset key must be defined in theme-i18n.json.

This is defined in the `theme-i18n.json` file that the Gutenberg plugin has, but not in the core one.

As a result, even if a theme developer releases a theme with radius presets, they cannot make the preset names translatable.

We need to the following keys:

{
	"settings": {
		"border": {
			"radiusSizes": [
				{
					"name": "Border radius size name"
				}
			]
		},
		"blocks": {
			"*": {
				"border": {
					"radiusSizes": [
						{
							"name": "Border radius size name"
						}
					]
				}
			}
		}
	}
}

Change History (21)

#1 @wildworks
8 weeks ago

  • Milestone changed from Awaiting Review to 6.9.1

Since the radiusSizes is a new feature in 6.9, let's consider fixing it in a point release.

#2 @wildworks
8 weeks ago

  • Version set to trunk

#3 @wildworks
8 weeks ago

  • Summary changed from I18N: border.radiusSizes key is missing in theme-i18n,json to I18N: border.radiusSizes key is missing in theme-i18n.json

#4 @hbhalodia
8 weeks ago

Hi @wildworks, I would like to work on this. Raising the PR with a fix.

Thanks.

This ticket was mentioned in PR #10580 on WordPress/wordpress-develop by @wildworks.


8 weeks ago
#5

  • Keywords has-patch added

#6 @wildworks
8 weeks ago

@hbhalodia I have already submitted a PR.

#7 @wildworks
8 weeks ago

  • Description modified (diff)

#8 @hbhalodia
8 weeks ago

Alright, Thanks @wildworks

@mukesh27 commented on PR #10580:


8 weeks ago
#9

Thanks. Have you found the issue in which border.radiusSizes key introduced?

@wildworks commented on PR #10580:


8 weeks ago
#10

Thanks. Have you found the issue in which border.radiusSizes key introduced?

Here: https://core.trac.wordpress.org/ticket/63799

#11 @wildworks
8 weeks ago

  • Description modified (diff)

@twvania commented on PR #10580:


8 weeks ago
#12

Thanks. Have you found the issue in which border.radiusSizes key introduced?

For more context, you can also check this link: Border Radius Size Presets in WordPress 6.9.

#13 @wildworks
8 weeks ago

I also submitted a similar PR to the i18n.command repo: https://github.com/wp-cli/i18n-command/pull/468

cc @swissspidy

#14 @swissspidy
8 weeks ago

It seems like every time this file is updated in Gutenberg it's forgotten to do the same in core. This should really be documented somewhere as part of the Gutenberg -> core process.

cc @ellatrix @youknowriad

@umeshsinghin commented on PR #10580:


8 weeks ago
#15

@t-hamano, The structure looks correct and matches the expected JSON schema. The key naming (radiusSizes) is clear and makes sense. Overall, the code looks good.

#16 @swissspidy
7 weeks ago

  • Keywords commit added

#17 @wildworks
7 weeks ago

  • Owner set to wildworks
  • Status changed from new to assigned

#18 @wildworks
7 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 61361:

I18N: add border.radiusSizes key to theme-i18n.json

Makes border radius size name property translatable by updating theme.json i18n schema.

Props hbhalodia, mukesh27, swissspidy, twvania, umeshsinghin, wildworks.
Fixes #64333.

#19 @wildworks
7 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening #64333 to request backporting [61361] to 6.9 branch.

#20 @SergeyBiryukov
7 weeks ago

  • Keywords fixed-major dev-reviewed added

[61361] looks good to backport.

#21 @wildworks
7 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 61366:

I18N: add border.radiusSizes key to theme-i18n.json

Makes border radius size name property translatable by updating theme.json i18n schema.

Reviewed by SergeyBiryukov.
Merges [61361] to the 6.9 branch.

Props hbhalodia, mukesh27, swissspidy, twvania, umeshsinghin, wildworks, SergeyBiryukov.
Fixes #64333.

Note: See TracTickets for help on using tickets.