Opened 8 weeks ago
Closed 7 weeks ago
#64333 closed defect (bug) (fixed)
I18N: border.radiusSizes key is missing in theme-i18n.json
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.9.1 | Priority: | normal |
| Severity: | normal | Version: | 6.9 |
| Component: | I18N | Keywords: | has-patch commit fixed-major dev-reviewed |
| Focuses: | Cc: |
Description (last modified by )
Related to #63799
Originally reported at https://github.com/WordPress/gutenberg/issues/73688 by @twvania
For preset names to be translatable, the preset key must be defined in theme-i18n.json.
This is defined in the `theme-i18n.json` file that the Gutenberg plugin has, but not in the core one.
As a result, even if a theme developer releases a theme with radius presets, they cannot make the preset names translatable.
We need to the following keys:
{
"settings": {
"border": {
"radiusSizes": [
{
"name": "Border radius size name"
}
]
},
"blocks": {
"*": {
"border": {
"radiusSizes": [
{
"name": "Border radius size name"
}
]
}
}
}
}
}
Change History (21)
#3
@
8 weeks ago
- Summary changed from I18N: border.radiusSizes key is missing in theme-i18n,json to I18N: border.radiusSizes key is missing in theme-i18n.json
This ticket was mentioned in PR #10580 on WordPress/wordpress-develop by @wildworks.
8 weeks ago
#5
- Keywords has-patch added
Trac ticket: https://core.trac.wordpress.org/ticket/64333
@mukesh27 commented on PR #10580:
8 weeks ago
#9
Thanks. Have you found the issue in which border.radiusSizes key introduced?
@wildworks commented on PR #10580:
8 weeks ago
#10
Thanks. Have you found the issue in which
border.radiusSizeskey introduced?
@twvania commented on PR #10580:
8 weeks ago
#12
Thanks. Have you found the issue in which
border.radiusSizeskey introduced?
For more context, you can also check this link: Border Radius Size Presets in WordPress 6.9.
#13
@
8 weeks ago
I also submitted a similar PR to the i18n.command repo: https://github.com/wp-cli/i18n-command/pull/468
cc @swissspidy
#14
@
8 weeks ago
It seems like every time this file is updated in Gutenberg it's forgotten to do the same in core. This should really be documented somewhere as part of the Gutenberg -> core process.
cc @ellatrix @youknowriad
@umeshsinghin commented on PR #10580:
8 weeks ago
#15
@t-hamano, The structure looks correct and matches the expected JSON schema. The key naming (radiusSizes) is clear and makes sense. Overall, the code looks good.
Since the radiusSizes is a new feature in 6.9, let's consider fixing it in a point release.