Make WordPress Core

Opened 6 weeks ago

Closed 4 weeks ago

Last modified 6 days ago

#64564 closed enhancement (fixed)

Update Google Fonts collection for 7.0 release

Reported by: wildworks's profile wildworks Owned by: wildworks's profile wildworks
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch has-unit-tests commit add-to-field-guide needs-dev-note
Focuses: Cc:

Description (last modified by peterwilsoncc)

Related past tickets:

The current Google font collection data is not up-to-date, with the latest additions to the list of available fonts and the latest versions of the existing ones.

This ticket is the central ticket for updating Google Fonts in the 7.0 release.

From my understanding, the tasks should be performed in the following order:

  1. Get a Google Fonts API key.
  2. Clone google-fonts-to-wordpress-collection repo locally, update fonts, and submit a PR with the latest fonts. Example of past PRs:
  3. After the PR is merged, submit a meta ticket to have the font list hosted. Example of previous meta tickets:
  4. WARNING: To avoid priming the w.org CDN with failing requests, do not begin this step until after the meta tasks have been completed. After the new font is hosted, update the core code with the new URL. Example of past PRs:

cc @mmaattiiaass @peterwilsoncc @mikachan @dd32

Change History (15)

#1 @peterwilsoncc
6 weeks ago

@wildworks As the API uses the WordPress.org CDN, the meta ticket and commit will need to be completed before the PR for WordPress-Develop is created. This will ensure the CDN isn't primed with 404 responses.

I'll take the liberty of editing your description accordingly.

#2 @peterwilsoncc
6 weeks ago

  • Description modified (diff)

This ticket was mentioned in PR #10877 on WordPress/wordpress-develop by @wildworks.


5 weeks ago
#4

  • Keywords has-patch has-unit-tests added

#5 @wildworks
4 weeks ago

Sorry, PR #10877 was linked to this ticket by mistake.

#7 @dd32
4 weeks ago

  1. After the PR is merged, submit a meta ticket to have the font list hosted.

CDN updated.

Example Preview image:
https://s.w.org/images/fonts/wp-7.0/previews/sn-pro/sn-pro-200-italic.svg

This ticket was mentioned in PR #10891 on WordPress/wordpress-develop by @wildworks.


4 weeks ago
#8

Trac ticket: https://core.trac.wordpress.org/ticket/64564

## Use of AI Tools

This PR does not contain any AI-generated code.

### Testing Instructions

  • Access Appearance > Editor > Global Styles > TYpography section > Manage fonts button
  • Move to the "Install fonts" tab
  • Make sure font previews are displayed correctly.
  • Test installing and uninstalling fonts.
  • Apply the installed fonts to the block and verify that they are applied correctly.
  • In particular, test newly added fonts.

You can find newly added fonts here: https://github.com/WordPress/google-fonts-to-wordpress-collection/pull/51#:~:text=What%20new%20fonts%20will%20be%20added%3F

#9 @wildworks
4 weeks ago

Thanks @dd32!

The final step:

  1. WARNING: To avoid priming the w.org CDN with failing requests, do not begin this step until after the meta tasks have been completed. After the new font is hosted, update the core code with the new URL. Example of past PRs:

https://github.com/WordPress/wordpress-develop/pull/10891

#10 @peterwilsoncc
4 weeks ago

  • Keywords commit added

I've reviewed, tested and approved the linked pull request. This is good ready for committing.

@wildworks commented on PR #10891:


4 weeks ago
#11

@peterwilsoncc Thanks for the review!

#12 @wildworks
4 weeks ago

  • Owner set to wildworks
  • Resolution set to fixed
  • Status changed from new to closed

In 61622:

Editor: Update Google Fonts API endpoint for WordPress 7.0.

Props dd32, mikachan, peterwilsoncc, wildworks.
Fixes #64564.

@wildworks commented on PR #10877:


4 weeks ago
#13

Oh, I re-forked the wordpress-develop repo and it seems all my submitted open PRs were closed 😂 I submitted a new PR that is equivalent to this one. https://github.com/WordPress/wordpress-develop/pull/10922

#14 @audrasjb
6 days ago

  • Keywords add-to-field-guide needs-dev-note added

This is worth mentioning in the Field Guide.
Also adding needs-dev-note just in case we can mention it in a more general note.

#15 @wildworks
6 days ago

Font library updates have been released without any mention in the FieldGuide, and since they have no impact on developers, I don't think a Field Guide is necessary.

Note: See TracTickets for help on using tickets.