Make WordPress Core

Opened 2 months ago

Closed 5 weeks ago

#64759 closed defect (bug) (fixed)

[Admin Reskin] Media modal “Edit Image” and help link use old color scheme

Reported by: huzaifaalmesbah's profile huzaifaalmesbah Owned by: audrasjb's profile audrasjb
Milestone: 7.0 Priority: normal
Severity: normal Version: trunk
Component: Media Keywords: admin-reskin has-screenshot has-patch changes-requested
Focuses: css Cc:

Description

In the Media Library modal (Select Image screen), the following links still use the old admin color scheme:

  • “Edit Image”
  • “Learn how to describe the purpose of the image” (help link under Alt Text)

These links do not reflect the updated Admin Reskin color tokens and appear to rely on old link color.

Steps to reproduce:

  1. Open Media Library
  2. Select an image
  3. Observe the link colors in the right sidebar

Expected behavior:

Links inside the media modal should follow the updated admin color system instead of the old color scheme.

Attachments (3)

Huzaifa-20260228142318.png (313.4 KB) - added by huzaifaalmesbah 2 months ago.
before-patch.png (95.4 KB) - added by shailu25 2 months ago.
Before Patch
after-patch.png (92.3 KB) - added by shailu25 2 months ago.
After Patch

Download all attachments as: .zip

Change History (16)

This ticket was mentioned in PR #11091 on WordPress/wordpress-develop by @hmbashar.


2 months ago
#1

  • Keywords has-patch added

#2 @noruzzaman
2 months ago

Test Report

Patch tested: https://github.com/WordPress/wordpress-develop/pull/11091

Environment

  • WordPress: 7.0-beta2-20260228.085804
  • PHP: 7.4.33
  • Server: PHP.wasm
  • Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
  • Browser: Chrome 145.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Eleven 5.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1

Actual Results

  1. ✅ Issue resolved with patch.
Before After
https://i.ibb.co/twPJNgpC/before.jpg https://i.ibb.co/Y7MbsVgx/after.jpg

#3 @mukesh27
2 months ago

  • Keywords changes-requested added

#4 @audrasjb
2 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

Thanks for spotting this, self assigning for final review.
It would be nice to test this changeset with other Admin Color Schemes, too.

#5 @audrasjb
2 months ago

  • Milestone changed from Awaiting Review to 7.0
  • Version set to trunk

#6 @shailu25
2 months ago

Test Report

This Report Validates that the indicated patch address the issue.✅

Patch Tested: https://github.com/WordPress/wordpress-develop/pull/11091

Environment:

WordPress - 7.0-beta2-20260301.074232
OS - Windows
Browser - Chrome
Theme: Twenty Twenty Five
PHP - 8.2.30
Plugin - None

Actual Results:

  • Issue Resolved with Patch ✅

Supplemental Artifacts

  • Attached

@shailu25
2 months ago

Before Patch

@shailu25
2 months ago

After Patch

#7 @manhar
2 months ago

Tested. Media modal link colors now follow the admin theme variables. Working as expected.

Before Patch :
https://postimg.cc/rzY5GXtJ

After Patch :
https://postimg.cc/jCC7Sgky

#8 @amin7
8 weeks ago

Test Report

Description


This report validates whether the indicated patch works as expected.

Patch tested:https://github.com/WordPress/wordpress-develop/pull/11091


Environment

WordPress: 7.0-beta3
PHP: 8.2.7
Server: ngnix
Browser: Chrome 145.0.0.0
OS: macOS
Theme: Twenty Twenty-Five
MU Plugins: None activated

Before Patch:
https://d.pr/i/YnKfhT

After Patch
https://d.pr/i/1be3DT

Result

✅ Issue resolved with this patch.

#9 @amin7
8 weeks ago

Hi @audrasjb

Should we also consider changing the color of infromation help icon https://d.pr/v/5z1tVt of the edit option from the media library? It seems here is the old color scheme, https://d.pr/i/cLxtdd

Thanks

#10 @amesplant
8 weeks ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested:https://github.com/WordPress/wordpress-develop/pull/11091

Environment

  • OS: macOS Tahoe (26.3)
  • Web Server: Server Name X.Y.Z
  • PHP: 8.2.7
  • Server: ngnix
  • WordPress: WordPress: 7.0-beta3
  • Browser: Chrome 145.0.7632.160
  • Theme: Twenty Twenty-Five

Actual Results

  • ✅ Issue resolved with patch.

Additional Notes

  • Adding that when switching color themes, the links also reflect the new scheme colors

@audrasjb commented on PR #11091:


7 weeks ago
#11

Hello there, I performed a final review and I think the following items need to be addressed:

  1. Use the new color scheme for the information icon
  2. Use the compact size for inputs so the button is the same size than the text inputs

https://github.com/user-attachments/assets/3757decc-3d1b-4a59-9f96-5737e4db669f

For (2), alternatively we can just put the button on a new line, just like in the Crop section:

https://github.com/user-attachments/assets/eb9d2092-c881-4da5-917d-d8413aa77721

@audrasjb commented on PR #11091:


5 weeks ago
#12

Looks good to me, now. Approved.
![Uploading screencapture-playground-wordpress-net-2026-03-24-07_10_01.png…]()

#13 @audrasjb
5 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 62098:

Media: Implement admin UI changes in the "Edit Image" screen and modal.

This changeset fixes some missing implementations of the new Admin UI in buttons and help links located on the "Edit Image" screen and within the related modal.

Props huzaifaalmesbah, hmbashar, audrasjb, mukesh27, wildworks, noruzzaman, shailu25, manhar, amin7, amesplant.
Fixes #64759.
See #64308.

Note: See TracTickets for help on using tickets.