Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 2 months ago

#65767 closed defect (bug) (fixed)

Media dialog selection info is no longer visible

Reported by: afercia Owned by: afercia
Priority: normal Milestone: 7.1
Component: Media Version: 7.1
Severity: normal Keywords: has-screenshots has-patch commit
Cc: Focuses:

Description

This appears to be a regression on trunk. Marking as such.

In the media dialog, when multiple selection is allowed, for example when inserting a gallery block, the media dialog shows small thumbnail preview of the selected media in the bottom toolbar.

These are the selection-info and selection-view containers in the markup.

They are no longer visible on trunk, though the markup is there.

After some quick inspection, I couldn't find relevant changes in the related CSS, although I may be missing something. I'd suggest to double check any change in the related markup first.

In the responsive view, the bug does not occurr. Note that in the responsive view, the bottom toolbar only shows some summary information e.g.: '6 items seleccted' plus a 'Clear' button.

See attached screenshots.

Attachments (3)

01 trunk.png​ (981.9 KB ) - added by afercia 3 months ago.
Media selection not visible on trunk.
02 7.0.png​ (554.8 KB ) - added by afercia 3 months ago.
Media selection visible on WP 7.0.
03 trunk mobild.png​ (76.8 KB ) - added by afercia 3 months ago.
Media selection visible on trunk, responsive view.

Download all attachments as: .zip

Change History (11)

@afercia
3 months ago

Media selection not visible on trunk.

@afercia
3 months ago

Media selection visible on WP 7.0.

@afercia
3 months ago

Media selection visible on trunk, responsive view.

This ticket was mentioned in ​PR #12784 on ​WordPress/wordpress-develop by ​@sukhendu2002.


3 months ago
#1

  • Keywords has-patch added

​@mukesh27 commented on ​PR #12784:


3 months ago
#2

This behavior was originally introduced in https://core.trac.wordpress.org/ticket/65275. Could you verify that this change doesn't inadvertently reintroduce the issue that ticket was intended to fix?

​@sukhendu2002 commented on ​PR #12784:


3 months ago
#3

Verified against the #65275 test instructions. The change scopes position: relative to .attachments-browser .media-toolbar-secondary, which still contains the filter spinner, so the #65275 positioning behavior is preserved.

https://github.com/user-attachments/assets/88f7cd9e-1be0-4abe-beaf-8218803bcb7a

#4 @afercia
3 months ago

  • Owner set to afercia
  • Status new → assigned

​@afercia commented on ​PR #12784:


3 months ago
#5

@Sukhendu2002 thank you for the PR. Makes sense.
No worries for the spinner position, it needs to be addressed anyways as there's a few issues with it and it's tracked in https://core.trac.wordpress.org/ticket/65778

#6 @afercia
3 months ago

  • Keywords commit added

#7 @afercia
3 months ago

  • Resolution → fixed
  • Status assigned → closed

In 62962:

Media: Restore selection previews in the Media dialog bottom toolbar.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/12784

Props sukhendu2002, mukesh27, iqbal1hossain, afercia.
Fixes #65767.

#8 @joedolson
2 months ago

#65886 was marked as a duplicate.

Note: See TracTickets for help on using tickets.