WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#6732 closed feature request (fixed)

Should Be Allowed to Edit Other Plugin Files

Reported by: cpoteet Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

Pre 2.5 you used to be able to edit any file in the file editor, but now it's only restricted to php files. Can it at least be allowed for some common extensions such as .css, .txt, .html, .htm?

Change History (12)

comment:1 thee176 years ago

  • Milestone changed from 2.5.2 to 2.7

comment:2 caesarsgrunt6 years ago

+1

Actually I'd rather get rid of the editor alltogether, but if you're going to have it it ought to be able to edit all of the plugin files.

And also, the author should be able to disable eiting of their plugin (even when it is disabled). But that should be another ticket, I guess...

comment:3 markjaquith6 years ago

  • Milestone changed from 2.7 to 2.8

I don't lean strongly either way, but in any case, it's missing the boat for 2.7. Let's throw up some pros/cons and consider it for a later version.

comment:4 follow-up: ryan5 years ago

  • Milestone changed from 2.8 to 2.9
  • Type changed from enhancement to feature request

Changing to version 2.9 to allow discussion time, since 2.8 dev cycle so short.

Wouldn't disabling the editing of plugin files kind of go against the open source nature of WordPress?

comment:5 mrmist5 years ago

I've only used the plugin editor when debugging my own plugin, but in general I think if the editor remains, then it should be able to edit any and all text-editable files within the plugin directory. Otherwise it just opens up potential for support threads asking "why can't I edit X file in the plugin editor?", which would then be a recurring pain or yet another sticky thread in the support forums.

Not only that, but if someone really wanted to edit the "restricted" plugins they could just edit the files directly in their editor of choice outside WP.

So +1 to allowing general editing again and -1 to restricting it.

comment:6 in reply to: ↑ 4 caesarsgrunt5 years ago

Replying to ryan:

Wouldn't disabling the editing of plugin files kind of go against the open source nature of WordPress?

No, I don't see why. It's still open source - the plugin editor doesn't let you edit core WP files, anyway, and removing the editor doesn't stop those who want to from editing the files or remove their entitlement to do so.

Replying to mrmist:

if someone really wanted to edit the "restricted" plugins they could just edit the files directly in their editor of choice outside WP.

Advanced users can edit all of the plugin files in their text editors, and less advanced users are likely to break their plugins by experimenting with the editor.
And it'll be one less bit of the UI for new users to understand...

Personally, I go for removing it or disabling it by default.

But if it is there, it should certainly be able to edit all files.
It should also have syntax highlighting if it is to be of any use whatsoever, IMO.
And there should be a prominent warning above it about the possible consequences of editing plugin files.

comment:7 ryan5 years ago

  • Milestone changed from 2.9 to 2.8

comment:8 ryan5 years ago

(In [10627]) Allow editing all of a plugin's files. see #6732

comment:9 follow-up: ryan5 years ago

Todo: Exclude binary files. Better presentation of long file lists.

comment:10 in reply to: ↑ 9 jbsil5 years ago

Replying to ryan:

Todo: Exclude binary files. Better presentation of long file lists.

See: #9452

comment:11 sivel5 years ago

  • Keywords dev-feedback removed
  • Resolution set to fixed
  • Status changed from new to closed

This has been implemented in 2.8 under a different ticket number

comment:12 cpoteet5 years ago

  • Cc cpoteet@… added

Thanks for doing this. After checking permissions on a CSS file I'm still getting the "Sorry, that file can't be edited" text.

Note: See TracTickets for help on using tickets.