WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#7685 closed defect (bug) (invalid)

No closing PHP tag in functions.wp-styles.php and functions.wp-scripts.php

Reported by: alexrabe Owned by:
Milestone: Priority: lowest
Severity: minor Version:
Component: Optimization Keywords:
Focuses: Cc:

Description

Is there a reason why the two files (functions.wp-styles.php and functions.wp-scripts.php) didn't contain a closing ?> for the PHP script ?

Change History (3)

comment:1 @Otto426 years ago

  • Milestone 2.7 deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version 2.7 deleted

No closing ?> tag is the preferred style in most web applications. This prevents accidental whitespace at the end of the file from being output prematurely (before headers and such are sent).

While it's not generally the style in WordPress, it is the recommended style by virtually all of the PHP community.

comment:2 @jacobsantos6 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Actually, the reason is that the two files, as well as two other files are part of BackPress and not of WordPress, which has the convention of including the closing PHP tag.

You may create a ticket at http://backpress.automattic.com/ and see what is said there.

This is actually invalid, since it isn't part of WordPress.

comment:3 @jacobsantos6 years ago

  • Resolution set to invalid
  • Status changed from reopened to closed

Not part of WordPress. See BackPress.

Note: See TracTickets for help on using tickets.