Make WordPress Core

Opened 18 years ago

Closed 17 years ago

#8695 closed feature request (fixed)

Send email for approved comments once

Reported by: Denis-de-Bernardy Owned by:
Priority: normal Milestone: 2.8
Component: Administration Version: 2.7
Severity: minor Keywords: has-patch
Cc: Focuses:

Description

Shouldn't this be the default behavior in WP?

http://wordpress.org/extend/plugins/filter-email-notifications/

Attachments (2)

8695.diff (673 bytes ) - added by Denis-de-Bernardy 17 years ago.
wp-includes--pluggable.php.diff (742 bytes ) - added by josephscott 17 years ago.

Download all attachments as: .zip

Change History (12)

#1 @mrmist
18 years ago

  • Milestone 2.7.12.8
  • Type defect (bug)feature request

Not really a bug, as the current behaviour could be useful in some cases (I.E. multiple people sharing a login/email.)

Could be added as an option I suppose...

#2 @Denis-de-Bernardy
18 years ago

Honestly, I doubt that sending an email would make sense in the use-case you mention. If I've an editor who uses my account, I probably don't care to receive an email when he approves a comment.

#3 @mrmist
18 years ago

The case I was considering was

  1. Email is sent to say comment is awaiting moderation (this goes to a list or shared mailbox)
  2. Someone logs on to approve said comment.
  3. A further mail is sent out, the other people on that list then know that they don't need to moderate that comment.

I'm not fussed either way. As I said, the idea has potential as an option.

#4 @FFEMTcJ
18 years ago

  • Milestone 2.8Future Release

#5 @Denis-de-Bernardy
17 years ago

  • Keywords has-patch added
  • Milestone Future Release2.8

#6 @ryan
17 years ago

  • Resolutionfixed
  • Status newclosed

(In [11057]) Don't notify post author of own comments. Props Denis-de-Bernardy. fixes #8695

#7 @ryan
17 years ago

(In [11057]) Don't notify post author of own comments. Props Denis-de-Bernardy. fixes #8695

#8 @josephscott
17 years ago

  • Resolution fixed
  • Status closedreopened

The initial change for this was incorrect. The check should be explicitly for the post author user ID and the comment user ID. I've included a simple patch to make this change.

Currently in the case where the post author is moderating comments the current check always matches because it's looking at the current user.

#9 @Denis-de-Bernardy
17 years ago

very correct.

/me bangs his head on a wall.

#10 @ryan
17 years ago

  • Resolutionfixed
  • Status reopenedclosed

(In [11387]) Don't notify post author of own comments. PrProps josephscott. fixes #8695

Note: See TracTickets for help on using tickets.