WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9589 closed defect (bug) (fixed)

Background color on widget control with blue admin

Reported by: arena Owned by: Nicholas91
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: Widgets Keywords: reporter-feedback
Focuses: Cc:

Description

When in blue admin layout

the widget control should have a background color

currently transparent

Attachments (5)

blue.jpg (22.2 KB) - added by arena 5 years ago.
grey.jpg (18.9 KB) - added by arena 5 years ago.
colors-classic.diff (369 bytes) - added by arena 5 years ago.
9589.diff (369 bytes) - added by arena 5 years ago.
rename of the previous diff file
colors-classic.css (29.6 KB) - added by Nicholas91 5 years ago.
Working patch.

Download all attachments as: .zip

Change History (17)

comment:1 ryan5 years ago

  • Component changed from Administration to Widgets
  • Owner anonymous deleted

arena5 years ago

arena5 years ago

comment:2 in reply to: ↑ description arena5 years ago

  • Keywords has-patch added

Replying to arena:

When in blue admin layout

the widget control should have a background color

currently transparent

arena5 years ago

comment:3 arena5 years ago

  • Owner set to arena

comment:4 arena5 years ago

  • Keywords needs-testing added

comment:5 arena5 years ago

  • Version set to 2.8

arena5 years ago

rename of the previous diff file

comment:6 ryan5 years ago

  • Owner changed from arena to azaozz

Nicholas915 years ago

Working patch.

comment:7 Nicholas915 years ago

  • Cc dragos.nicholas@… added
  • Keywords tested commit added; needs-testing removed
  • Owner changed from azaozz to Nicholas91

I've added the correct patch.
It seems I can't use the

svn diff filename.css > filename.diff

command for CSS files...

Anyway, I've just added the "widget-inside" class to line 616 like so:

.metabox-holder .postbox,
#poststuff .postbox,
.widget-inside {
	background-color: #FFF;
}

Tested on Ubuntu/FireFox/Opera.

comment:8 follow-up: azaozz5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11146]) Add background color on widget control with blue admin, props arena, fixes #9589

comment:9 in reply to: ↑ 8 ; follow-up: Nicholas915 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to azaozz:

(In [11146]) Add background color on widget control with blue admin, props arena, fixes #9589

Azaozz, the patch from arena doesn't work! My patch solves the problem. Did you even read my last comment?
Just add the "widget-inside" class on line 616:
.metabox-holder .postbox,
#poststuff .postbox,
.widget-inside {

background-color: #FFF;

}

comment:10 Nicholas915 years ago

*in code tags*

.metabox-holder .postbox,
#poststuff .postbox,
.widget-inside {
	background-color: #FFF;
}

comment:11 in reply to: ↑ 9 azaozz5 years ago

  • Keywords reporter-feedback added; has-patch tested commit removed

Replying to Nicholas91:

Azaozz, the patch from arena doesn't work!

There was a difference between colors-fresh and colors-classic, the patch made them the same. Can you check why it doesn't work for you? .widget-inside is under .widget so background color on .widget shows for all child elements.

comment:12 Nicholas915 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Sorry azaozz, it was my fault. The patch is good. It didn't work when I've checked it 7 days ago.

Note: See TracTickets for help on using tickets.