Erroneous balanceTags call? forceBalanceTags should be used?

[Denis-de-Bernardy]

In get_the_content(), the more_link gets added after the call to balanceTags. Shouldn't it get added before it?

[markjaquith]

If it is added before it, you could get closing tags AFTER the more_link, which might be undesired. For instance, if you have a formatting div around your teaser, and you forget to close it. balanceTags would extend that div to enclose the more_link.

[Denis-de-Bernardy]

possibly. the only thing I do know is that this is one of those areas in the code that tends to break a lot.

this post, for instance, will almost invariably wreck a front page due to the fact that it's not enforcing balanceTags properly:

<div>

foo <!--more-->

</div>

shouldn't forceBalanceTags be used, rather than a straight balanceTags call?

[markjaquith]

So, force it just in this context (when there is a more_link)?

[Denis-de-Bernardy]

imo, yeah. try it on a theme that sets its layout with div tags. you're essentially guaranteed that things will break (i.e sidebars gets knocked down in IE) if you do not opt to use balanceTags in the first place.

[Denis-de-Bernardy]

this case is also tricky (and was the reason I suggested the initial patch:

<div>

<p>foo <!--more--></p>

</div>

the balanceTags call before the more tag, rather than after, prevents the more link from being appended to the end of the paragraph.

[Denis-de-Bernardy]

the tests *easily* break kubrick, btw. and the second patch makes things work as expected by the user in both cases.

[Denis-de-Bernardy]

Related: #6297

[ryan]

(In [11398]) Add more link and then force_balance_tags. Props Denis-de-Bernardy. fixes #9765