Custom Header Support in Default Theme

[Sewar]

Default theme contain custom header in it, version 2.1 implemented it in WP core, but default theme still use its custom code, it should use Custom_Header class.

Hate to sound stupid, but I can't find a Custom_Header class in the core...

Or are you suggesting we create a new class to deal with custom headers?

I think he's talking about the add_custom_image_header() function in wp_includes/theme.php and the Custom_image_header class wp_admin/custom-header.php.

Ahhh. That would make more sense.

As Otto42 said, i mean Custom_image_header class in custom-header.php​. As i said in description, custom header support implemented in WP 2.1, see [4673] and #3465.

Currently some (or most) of ​WP.com themes supports this feature, you can use them as a reference for create a patch.

The patch needs testing by another developer. It looks bad, but works.

Thanks for the patch!

Can wait till 2.3 , no reason to rush it in at the end.

The default theme does support custom coloring in the header though. It allows color fades. On worpress.com, Kubrick has both custom header image and custom header coloring, but they don't cooperate very well and the corner curves show beneath the custom image. I'll attach the default theme with the wpcom changes if someone wants to try making both custom coloring and custom images play nice together.

Are color fades necessary? Don't most users who use Custom Image Header, upload their own images? It should be one or the other and not both at the same time. Custom Image Header should trump color fade if used.

With a new default theme (#9015) making it's way into 3.0, and the introduction of #12343 and register_default_headers(), with the possibility to soon (If not already in?) use a solid colour header, I think we can close this as a duplicate ticket! :)