WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11274 closed task (blessed) (fixed)

Review navigation labels in Admin menus

Reported by: lloydbudd Owned by: jane
Milestone: 3.0 Priority: low
Severity: minor Version: 2.9
Component: Administration Keywords: ux-feedback
Focuses: Cc:

Description

Remove "Edit" from title of each main admin page

ENV: 2.9-beta-1 (trunk r12287)

While writing up #11273, I noticed the Edit (button) comment could be confused with Edit Comments. Definitely makes it harder to write documentation.

Clicking each of Posts, Links, Pages I noticed they also have "Edit" in the title.

This is not on Appearance or Users though -- because it would be even weirder there. Another clue is that it isn't the case for Media, whose title is Media Library (and submenu item is Library).

It can be removed from each of these *main* admin pages. You might not be there to edit, just review... or maybe this is where you are used to Add New from.

ADDITIONAL DETAILS

The sidebar menu shows Edit for each of these options. I think that is OK -- I think there is a bigger issue here, but will save for another day; it sounds like there is related menu item work planned for 3.0 as well.

http://clearcapsule.com/blog/2009/09/fresh-fish-sold-here-today/

Please leave the target milestone as 3.0, ie not work on this ticket until after 2.9 has shipped -- ship it!

Attachments (1)

11274.diff (2.3 KB) - added by ryan 4 years ago.
Revert back to Edit

Download all attachments as: .zip

Change History (32)

comment:1 iammattthomas4 years ago

Sounds like a good complement to the design work in 3.0 that's being carried over from last summer. Less is more. :)

comment:2 follow-up: janeforshort4 years ago

  • Priority changed from normal to low
  • Severity changed from normal to minor

We're going to be reevaluating the whole menu for 3.0, so this individual ticket should not be a standalone item, but will be discussed during general menu decisions.

comment:3 in reply to: ↑ 2 lloydbudd4 years ago

  • Owner set to janeforshort
  • Status changed from new to assigned

comment:4 janeforshort4 years ago

  • Summary changed from Remove "Edit" from title of each main admin page to Review navigation labels in Admin menus

comment:5 nacin4 years ago

  • Owner changed from janeforshort to jane

comment:6 nacin4 years ago

  • Type changed from enhancement to task (blessed)

comment:7 dd324 years ago

Are there any planned changes here? Or is this being punted to 3.1?

comment:8 markmcwilliams4 years ago

  • Keywords title web page title admin page title removed

comment:9 nacin4 years ago

  • Keywords ux-feedback added

If we plan to do this, now would be a good time -- #12968.

comment:10 nacin4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14616]) Use 'Posts', 'Pages', and corresponding custom post type names as the edit.php title. fixes #12968, fixes #11274.

comment:11 nacin4 years ago

  • Keywords commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

If there are no objections I'm also going to change "Edit Links" and "Edit Comments" to "Links" and "Comments."

For reference, other screens in the "content" section of the menu are Post Tags, Categories, Media Library. And now Posts and Pages.

comment:13 nacin4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [14652]) Use 'Comments' and 'Links' as page title instead of Edit %s. fixes #11274.

comment:14 demetris4 years ago

  • Keywords commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

I am copying my comment from #12968:

START COPY

First, I believe that such prominent UI strings should not change unless there is a very good reason (which does not exist in this case).

Second, the new titles introduce unneeded and maybe confusing variety. What I mean: The menu subitem that sends you there is titled Edit. The screens for individual pages/posts are titled Edit Post and Edit Page. But the edit.php screens, which are the same thing but for more than one posts/pages, are now named just Posts and Pages.

END COPY

The comment applies, mutatis mutandis, to the rest of the mass edit/view screens as well.

comment:15 johnonolan4 years ago

The point is that you don't always get there from "clicking the menu subitem" which happens to be titled edit, and you don't always use the page for editing.

We discussed this at length and I think the right decision was made.

comment:16 ryan4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:17 jane4 years ago

I have to agree with Demetris. It's in now, and we're about to hit RC, but this change should not have been made until we were able to re-evaluate the menu labels on the left hand menu as well, which we did not do in 3.0. In the future, let's not jump to make ui changes like this.

comment:18 follow-up: jane4 years ago

I would argue that the link text in the menu should probably change from "Edit" to "Posts" since it goes to the same place as the section link (Posts) and we follow that convention in Tools. If in a future version we move to a tabbed UI for edit/add new, then Posts would encompass that.

comment:19 in reply to: ↑ 18 jane4 years ago

Replying to jane:

we follow that convention in Tools.

And Dashboard, and Comments when plugins add to that section, etc.

comment:20 jane4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

For consistency's sake:

  • on wp-admin/plugins.php change "Manage Plugins" to "Plugins"

in left nav, change labels:

  • "Posts > Edit" to "Posts > Posts"
  • "Links > Edit" to "Links > Links"
  • "Pages > Edit" to "Pages > Pages"
  • "Plugins > Installed" to "Plugins > Plugins" (the translators never like Installed as label anyway)
  • "Users > Authors & Users" to "Users > Users" (the header already only says users)

In a future version we should probably create an appearance overview screen that lists the current theme, widgets, custom things the theme offers, etc, but that's a separate issue.

comment:21 jane4 years ago

Sorry about that, the line breaks didn't stick. Here's the list, easier to read.

  • "Posts > Edit" to "Posts > Posts"
  • "Links > Edit" to "Links > Links"
  • "Pages > Edit" to "Pages > Pages"
  • "Plugins > Installed" to "Plugins > Plugins" (the translators never like Installed as label anyway)
  • "Users > Authors & Users" to "Users > Users" (the header already only says users)

comment:22 ryan4 years ago

(In [14838]) Manage Plugins -> Plugins. see #11274

comment:23 ryan4 years ago

Getting rid of the Edit prefix does help i18n of custom types, but we are getting a little crazy this late in the game. Translators are not going to be happy.

comment:24 jane4 years ago

I agree, but since changes to the headers got committed, the labels should match. It was not supposed to happen independently.

comment:25 demetris4 years ago

@johnonolan:

I am not aware of any in depth discussion on this. Where did it take
place?

@jane:

Changing more stuff at this stage is even worse in my opinion.

If it is not imperative that we ship an RC within the next few hours, I believe we should revert what has already changed, and look at the whole thing at a later time.

I can see no valid reason to change these strings for v3.0. And the changes that are already in are, as far as I understand, mostly for the convenience of the developers (to save us from some extra hassle required because of the new registration functions).

In any case, if a revert is desired, I can make/test/submit a patch within the next twelve hours.

comment:26 johnonolan4 years ago

@demetris - it was in IRC one day, nothing official. That being said, I misunderstood most of this slightly because of the language used... I thought that this was about page titles (as the original ticket would suggest) when it is in fact about page headings - which I agree merits much more thought/discussion, so my apologies here for lack of due dilligence.

ryan4 years ago

Revert back to Edit

comment:27 ryan4 years ago

That revers back to using Edit. We'd still need to add edit_items to post and taxonomy registration.

comment:28 ryan4 years ago

And if we go forward with changing the menu labels, it's a simple matter of tweaking menu.php.

comment:29 nacin4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [14856]) Use object names instead of 'Edit' in submenus. props jane, fixes #11274.

comment:30 nacin4 years ago

(In [14857]) Remove now-unused post_type_object->labels>edit, which was 'Edit' (with context). see #12968, see #11274.

comment:31 demetris4 years ago

All this is very disappointing.

I have no other comment that would be helpful here.

Note: See TracTickets for help on using tickets.