oembed not respecting Media -> Maximum embed size -> height

[philipsoutham]

When adding an oauth provider that is not in the current whitelist, via the following code in functions.php

add_action('init', 'movieclips_embeds');

function movieclips_embeds() {
    wp_oembed_add_provider( '#http://(www\.)?movieclips.com/watch/[\w]+/[\w]+/#i', 'http://movieclips.com/services/oembed/' , true);
}

The Maximum embed size "height" paramter (set in settings->media) seems to be ignored, sending a value of 700 to the provider unless explicitly set in the embed short tag. Please see attached screenshots for demonstration of bug to aid in my explanation.

[philipsoutham]

Showing that width is set to 560, height set to 304 in settings->media

[philipsoutham]

Showing methods of embedding media, without short tag, with short tag, and with short tag where width and height are explicitly set.

[philipsoutham]

Showing code to call function to add non-whitelisted oembed provider.

[philipsoutham]

Shows where height is statically set to 700 in wp-includes/media.php -> wp_embed_defaults function

[philipsoutham]

Showing movieclips oembed provider log where maxheight parameter is set to 700 for all requests except for the one where height is explicitly set in embed short tag.

[philipsoutham]

Showing embedded media on page as a result of publishing methods shown in attachment "post-content.png"

[philipsoutham]

Correction to original ticket entry; "oauth" shoud be "oembed". Too many o* protocols...

[Viper007Bond]

Hmm, how'd I manage that one?

[nacin]

IMO, should be considered for the 2.9 branch to repair expected functionality.

Summing up from IRC: While width is the typical limiting factor, if the oembed provider does not follow an aspect ratio then it would be apparent. Plus, the only thing worse than a core option is an option in core that doesn't work.

[ryan]

(In [12875]) Respect maximum embed height. Props Viper007Bond. fixes #11980