Context Navigation

← Previous Ticket
Next Ticket →

#14060 reviewing defect (bug)

Misleading "You do not have sufficient permissions to access this page."

Reported by:	hakre	Owned by:	SergeyBiryukov
Milestone:	Future Release	Priority:	normal
Severity:	normal	Version:	3.0
Component:	Plugins	Keywords:	has-patch needs-testing has-screenshots early
Focuses:		Cc:

Description

When accessing a page of a plugin in the admin that does not exists any longer, you're told by an error message, that:

You do not have sufficient permissions to access this page.

This message is a little misleading, because there is no such page.

A message that better reflects the decision to display it would be less misleading, e.g.:

The requested page is not accessible.

Attachments (6)

14060.patch (469 bytes) - added by hakre 14 years ago.: Simple Patch
14060-More-Information.diff (479 bytes) - added by envygeeks 14 years ago.: Better description
14060.2.patch (2.0 KB) - added by SergeyBiryukov 13 years ago.
14060.3.diff (2.3 KB) - added by Nikschavan 8 years ago.: Refreshed the patch
14060.4.diff (2.4 KB) - added by Nikschavan 7 years ago.: Refreshed the patch with current trunk
page-does-not-exist.png (150.1 KB) - added by Nikschavan 7 years ago.

Download all attachments as: .zip

Change History (29)

@hakre
14 years ago

Attachment 14060.patch added

Simple Patch

#1 @hakre
14 years ago

FYI: at the end of Plugin.php there are a lot of functions undocumented and in addition to that important global variables for the admin like $parent_file or $plugin_page are not documented as well.

#2 @nacin
14 years ago

Related, #14039

@envygeeks
14 years ago

Attachment 14060-More-Information.diff added

Better description

#3 @dd32
14 years ago

Keywords needs-patch added; has-patch removed

Both of those proposed wordings are not appropriate IMO.

The major case of that block is to prevent users accessing pages which they do not have access to, The current wording seems appropriate for that (A straight up, Permission denied message).

"The requested page is not accessible." - Doesn't convey the reason for the page being inaccessible.

An alternate solution could be such as follows to give non-existant pages a specific error:

if ( !admin_page_exists() ) {
 do_action...
 wp_die "non-existant page!"
} elseif ( !user_can_access_admin_page() ) {
 do_action...
 wp_die "You dont have access!...";
}