WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 4 years ago

Last modified 3 years ago

#15110 closed defect (bug) (fixed)

Useless MIME type served for rss feeds

Reported by: singpolyma Owned by: chriscct7
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.0
Component: Feeds Keywords: has-patch commit
Focuses: Cc:

Description

Both /feed/, /feed/rss2/, and /feed/rss/ are served using the very undescriptive and generally useless "text/xml" MIME type. ATOM and RDF feeds are served with their proper MIME types. It looks like the MIME types for RSS are in feed.php, but for some reason there is a special "rss-http" type that returns the useless type? Changing the first line in feed-rss.php and feed-rss2.php to use the rss and rss2 type instead of rss-http fixed it on my site.

Attachments (2)

rss-mime.patch (908 bytes) - added by singpolyma 9 years ago.
Patch I've used to fix this
15510.patch (1.6 KB) - added by chriscct7 4 years ago.

Download all attachments as: .zip

Change History (18)

@singpolyma
9 years ago

Patch I've used to fix this

#1 @singpolyma
9 years ago

  • Keywords has-patch added; mime removed

#2 @nkuttler
9 years ago

  • Keywords dev-feedback added

#3 @markjaquith
9 years ago

  • Milestone changed from Awaiting Review to Future Release

#4 @iridox
7 years ago

  • Keywords changed from has-patch, dev-feedback to has-patch dev-feedback

Can we get this added to the queue for 3.5 please?

#6 @SergeyBiryukov
7 years ago

Need to check if the wp-testers report and ticket:9810:5 still apply.

#7 @chriscct7
4 years ago

  • Keywords dev-feedback removed

Refreshed patch and added the rss2 header to the comments rss2 feed

@chriscct7
4 years ago

#8 @chriscct7
4 years ago

  • Owner set to chriscct7
  • Status changed from new to assigned

#9 @chriscct7
4 years ago

  • Milestone changed from Future Release to 4.3
  • Owner changed from chriscct7 to obenland
  • Status changed from assigned to reviewing

#10 @chriscct7
4 years ago

  • Keywords commit added
  • Owner changed from obenland to chriscct7
  • Status changed from reviewing to accepted

#11 @SergeyBiryukov
4 years ago

The patch essentially reverts [11334] and [11358].

Still need to make sure this does not reintroduce any issues mentioned in #9810 or in the wp-testers report.

#12 @chriscct7
4 years ago

This works for the couple of people on a Mac who've helped test it for me at LoopConf.

Apple actually serves their own feeds using application/rss+xml http://ax.itunes.apple.com/WebObjects/MZStore.woa/wpa/MRSS/justadded/limit=10/rss.xml

The previously mentioned download behavior in FireFox was actually a bug they fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=256379

#13 @wonderboymusic
4 years ago

Firefox works fine with both.
Chrome parses the old feeds with an XML parser, parses them as plain text with patch
Safari doesn't parse in either version but suggests downloading a feed reader

#14 @wonderboymusic
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 32468:

Serve RSS feeds with the proper mime-type: application/rss+xml. The reason for hacking around browsers by using text/xml appears to no longer be relevant.

Props @chriscct7.
Reverts [11334] and [11358]
Fixes #15110.

#15 @johnbillion
4 years ago

In 36230:

Feeds: Remove the rss-http feed type, unused since r32468.

See #15110

Note: See TracTickets for help on using tickets.