get_post_custom() should use use get_metadata()

[scribu]

I found out that get_post_custom() is equivalent to calling get_metadata() without a meta key, so we should use that.

[scribu]

almost equivalent

[scribu]

Related: #17013

[scribu]

Patch still applies cleanly.

[hakre]

Hmm, ​get_metadata() contains much more and different lines of code as what you remove with the proposed patch.

[scribu]

You've got it backwards: I'm replacing get_post_meta() with get_metadata(), not the other way around.

Of course get_metadata() contains much more code, since it's a more general function.

Please base your objections on tests, not on appearances.

[nacin]

I doubt this got the testing or considerations required here. First patch was marked for commit but it wouldn't have worked when ID = 0. As said in IRC, seems fine but not really a necessary change at this time. Punting.

[scribu]

#19708