Invited but not activated users can get lost

[filosofo]

Steps to reproduce:

• In Site Admin, go to Users > Add New
• Add a new user
• You get a message to the effect of, said user needs to respond to an invitation.

Now the user has disappeared. There's no way for a super admin or anybody to search for that user and add her directly, or delete her, or anything like that. If the user doesn't get the email, she's out of luck: that username and email are now reserved for "a couple of days."

[filosofo]

I think these limbo users should show up in the Network Admin list of users. If there's some agreement I can make a patch.

[ocean90]

Nothing new.

But I would prefere a list here too, maybe as a filter Pending on network/users.php and some action links like Send email again or Delete.

[filosofo]

Replying to ocean90:

Nothing new.

I don't think that's the case. In 3.0.x you cannot create a user in the admin that disappears. If I'm wrong, please give me the steps to reproduce. In the past, when you create a user in admin, it's there.

That's what makes this a regression.

[ocean90]

Check on network options Allow site administrators to add new users to their site via the "Users->Add New" page.

Then go to wp-admin/user-new.php and add a user but don't check Site administrators can add a user without sending the confirmation email.

You cannot see the user on any list.

If you want to add the same user again, you get the message That username is currently reserved but may be available in a couple of days.

[filosofo]

Ok. Even if it's not new, it's still a bug.

I would argue that it's much worse in 3.1 because it's easier to do, as it's allowed by default.

[garyc40]

first attempt to patch this bug

[garyc40]

I attached my first attempt to patch this bug. As I'm not yet familiar with the inner workings of multisite user system, I'm sure there's a lot of room for improvement (or even a total different approach). But I'd like to take a stab at fixing this and pick up a few things along the way, hence, 16001.diff .

There are a few issues / questions:

• user_login is not indexed in table wp_signups. There's also no ID column. As a result, querying, updating and deleting on this table based on user_login might be a performance hit.

• I don't know if wp_signups ever gets cleaned up (those items where active = 1)? If it does, could you point me to the code that does it?

[garyc40]

pending user filter

[garyc40]

bulk edit pending users

[r-a-y]

Replying to garyc40:

• I don't know if wp_signups ever gets cleaned up (those items where active = 1)? If it does, could you point me to the code that does it?

I was just wondering about this myself. wpmu_delete_user() doesn't appear to delete the accompanying data in the wp_signups table and was wondering if there was an underlying reason.

[SergeyBiryukov]

Closed #20817 as a duplicate.

[wonderboymusic]

I had to piece this patch together with my bare hands based on the old one, but I think this feature makes total sense and is a rare ray of hope in the dark gloomy world of Multisite - 3.2-early alum

[nacin]

Too late for this now, but I like it, so let's take another look early 3.7.

[wonderboymusic]

Updated the patch so it applies - wp-admin/includes/class-wp-ms-users-list-table.php was failing

[wonderboymusic]

these are all marked 3.7-early

[wonderboymusic]

I like this a lot, but scares me for right now

[SergeyBiryukov]

#27145 was marked as a duplicate.

[samuelsidler]

Still early enough for 3.9?

@wonderboymusic: How are you feeling about it now?

[wonderboymusic]

16001.4.diff​ refreshes this. I need to spend some time and remind myself what this does.

[Ipstenu]

@boone wrote this: ​https://wordpress.org/plugins/unconfirmed/

Which is what I suggest most people use for now. Should any of that be folded into the patch?

[ericlewis]

I like this, but I don't think adding a Pending Confirmation filter for the network admin Users table will solve the real issue here. That interface will be limited to super admin access. Regular site admins will still be in the dark.

[SergeyBiryukov]

Related: #31127

[Mista-Flo]

It's a really annoying behavior.

The plugin of @boonebgorges is still maintained (​https://wordpress.org/plugins/unconfirmed/), so it will be a nice helper to solve this ticket.

So How can we finish this, what final steps can we do ?

[jeremyfelt]

Replying to Mista-Flo:

It's a really annoying behavior.

Indeed. :)

The plugin of @boonebgorges is still maintained (​https://wordpress.org/plugins/unconfirmed/), so it will be a nice helper to solve this ticket.

So How can we finish this, what final steps can we do ?

Let's clarify what direction we need to take to solve this. We can then figure out how close Unconfirmed and/or existing patches get us and what else needs to be done to finish.

Some questions:

• Does it make sense to add "Pending" users to both the network admin users list table and the individual site users list table?
• If yes, do "Pending" users display in the list by default or only when "Pending" is selected.
• If no, what other interface would make sense?
• What actions should be available for a pending user? Resend, cancel/delete, manually confirm?

I'd be okay with starting to push on this to be in a place for the next cycle or two.

[dd32]

I ran into this a few days ago on a large network, only after realising I'd invited the wrong person to be an Admin.. and couldn't find a way to cancel the request..

Does it make sense to add "Pending" users to both the network admin users list table and the individual site users list table?

I kind of expect it in both locations, although I don't feel too strongly about the network admin list.

If yes, do "Pending" users display in the list by default or only when "Pending" is selected.

When Pending is selected IMHO

What actions should be available for a pending user? Resend, cancel/delete, manually confirm?

I'd expect Cancel/Delete, and Manually Confirm as a user with the right caps. I'm not sure how often Resend would be needed, but it makes sense to me - I don't think there's a way to do that at present?

[Ipstenu]

although I don't feel too strongly about the network admin list.

I think it's needed since network admins can invite without being on a specific site :)

Other than that, I agree with Dion :)

[SergeyBiryukov]

#51724 was marked as a duplicate.

[ehtis]

Like others, I ended up inviting the wrong username to a multisite (quite a large network!).
Even as super admin one can't revoke the invite.

Would be wonderful to have this feature added some day. :)