WordPress.org

Make WordPress Core

Opened 9 years ago

Last modified 2 years ago

#16001 new defect (bug)

Invited but not activated users can get lost

Reported by: filosofo Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Users Keywords: needs-patch
Focuses: multisite Cc:
PR Number:

Description

Steps to reproduce:

  • In Site Admin, go to Users > Add New
  • Add a new user
  • You get a message to the effect of, said user needs to respond to an invitation.

Now the user has disappeared. There's no way for a super admin or anybody to search for that user and add her directly, or delete her, or anything like that. If the user doesn't get the email, she's out of luck: that username and email are now reserved for "a couple of days."

Attachments (6)

16001.diff (17.2 KB) - added by garyc40 9 years ago.
first attempt to patch this bug
pending-users.png (43.8 KB) - added by garyc40 9 years ago.
pending user filter
bulk-edit.png (42.9 KB) - added by garyc40 9 years ago.
bulk edit pending users
16001.2.diff (19.1 KB) - added by wonderboymusic 7 years ago.
16001.3.diff (19.6 KB) - added by wonderboymusic 6 years ago.
16001.4.diff (17.8 KB) - added by wonderboymusic 6 years ago.

Download all attachments as: .zip

Change History (39)

#1 @filosofo
9 years ago

I think these limbo users should show up in the Network Admin list of users. If there's some agreement I can make a patch.

#2 follow-up: @ocean90
9 years ago

  • Milestone changed from 3.1 to Future Release
  • Type changed from defect (bug) to enhancement

Nothing new.

But I would prefere a list here too, maybe as a filter Pending on network/users.php and some action links like Send email again or Delete.

#3 in reply to: ↑ 2 @filosofo
9 years ago

  • Milestone changed from Future Release to 3.1
  • Type changed from enhancement to defect (bug)

Replying to ocean90:

Nothing new.

I don't think that's the case. In 3.0.x you cannot create a user in the admin that disappears. If I'm wrong, please give me the steps to reproduce. In the past, when you create a user in admin, it's there.

That's what makes this a regression.

#4 @ocean90
9 years ago

  • Milestone changed from 3.1 to Future Release
  • Type changed from defect (bug) to enhancement
  • Version changed from 3.1 to 3.0

Check on network options Allow site administrators to add new users to their site via the "Users->Add New" page.

Then go to wp-admin/user-new.php and add a user but don't check Site administrators can add a user without sending the confirmation email.

You cannot see the user on any list.

If you want to add the same user again, you get the message That username is currently reserved but may be available in a couple of days.

#5 @filosofo
9 years ago

  • Type changed from enhancement to defect (bug)

Ok. Even if it's not new, it's still a bug.

I would argue that it's much worse in 3.1 because it's easier to do, as it's allowed by default.

@garyc40
9 years ago

first attempt to patch this bug

#6 follow-up: @garyc40
9 years ago

  • Keywords has-patch needs-testing needs-review 3.2-early added; needs-patch removed

I attached my first attempt to patch this bug. As I'm not yet familiar with the inner workings of multisite user system, I'm sure there's a lot of room for improvement (or even a total different approach). But I'd like to take a stab at fixing this and pick up a few things along the way, hence, 16001.diff .

There are a few issues / questions:

  • user_login is not indexed in table wp_signups. There's also no ID column. As a result, querying, updating and deleting on this table based on user_login might be a performance hit.
  • I don't know if wp_signups ever gets cleaned up (those items where active = 1)? If it does, could you point me to the code that does it?

@garyc40
9 years ago

pending user filter

@garyc40
9 years ago

bulk edit pending users

#7 in reply to: ↑ 6 @r-a-y
9 years ago

Replying to garyc40:

  • I don't know if wp_signups ever gets cleaned up (those items where active = 1)? If it does, could you point me to the code that does it?

I was just wondering about this myself. wpmu_delete_user() doesn't appear to delete the accompanying data in the wp_signups table and was wondering if there was an underlying reason.

#8 @SergeyBiryukov
7 years ago

Closed #20817 as a duplicate.

#9 @wonderboymusic
7 years ago

  • Keywords dev-feedback added; needs-testing needs-review removed
  • Milestone changed from Future Release to 3.6

I had to piece this patch together with my bare hands based on the old one, but I think this feature makes total sense and is a rare ray of hope in the dark gloomy world of Multisite - 3.2-early alum

#10 @nacin
7 years ago

  • Keywords 3.7-early added; 3.2-early dev-feedback removed
  • Milestone changed from 3.6 to Future Release

Too late for this now, but I like it, so let's take another look early 3.7.

#11 @wonderboymusic
6 years ago

  • Keywords needs-testing added
  • Milestone changed from Future Release to 3.7

Updated the patch so it applies - wp-admin/includes/class-wp-ms-users-list-table.php was failing

#12 @wonderboymusic
6 years ago

these are all marked 3.7-early

#13 @wonderboymusic
6 years ago

  • Keywords needs-testing removed
  • Milestone changed from 3.7 to 3.8

I like this a lot, but scares me for right now

#14 @SergeyBiryukov
6 years ago

  • Milestone changed from 3.8 to Future Release

#15 @SergeyBiryukov
6 years ago

#27145 was marked as a duplicate.

#16 @samuelsidler
6 years ago

  • Keywords 3.9-early added; 3.7-early removed

Still early enough for 3.9?

@wonderboymusic: How are you feeling about it now?

#17 @wonderboymusic
6 years ago

16001.4.diff refreshes this. I need to spend some time and remind myself what this does.

#18 @Ipstenu
6 years ago

@boone wrote this: https://wordpress.org/plugins/unconfirmed/

Which is what I suggest most people use for now. Should any of that be folded into the patch?

#19 @SergeyBiryukov
6 years ago

  • Focuses multisite added

#20 @ericlewis
5 years ago

  • Summary changed from Invited Users Can Disappear in MS to Invited but not activated users can get lost

#21 @ericlewis
5 years ago

I like this, but I don't think adding a Pending Confirmation filter for the network admin Users table will solve the real issue here. That interface will be limited to super admin access. Regular site admins will still be in the dark.

Last edited 5 years ago by ericlewis (previous) (diff)

This ticket was mentioned in Slack in #core-multisite by eric. View the logs.


5 years ago

This ticket was mentioned in Slack in #core-multisite by rdall. View the logs.


4 years ago

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


4 years ago

This ticket was mentioned in Slack in #core-multisite by richardtape. View the logs.


4 years ago

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


4 years ago

#28 follow-up: @Mista-Flo
3 years ago

It's a really annoying behavior.

The plugin of @boonebgorges is still maintained (https://wordpress.org/plugins/unconfirmed/), so it will be a nice helper to solve this ticket.

So How can we finish this, what final steps can we do ?

This ticket was mentioned in Slack in #core-multisite by florian-tiar. View the logs.


3 years ago

#30 in reply to: ↑ 28 @jeremyfelt
3 years ago

  • Keywords needs-patch added; has-patch 3.9-early removed
  • Severity changed from major to normal

Replying to Mista-Flo:

It's a really annoying behavior.

Indeed. :)

The plugin of @boonebgorges is still maintained (https://wordpress.org/plugins/unconfirmed/), so it will be a nice helper to solve this ticket.

So How can we finish this, what final steps can we do ?

Let's clarify what direction we need to take to solve this. We can then figure out how close Unconfirmed and/or existing patches get us and what else needs to be done to finish.

Some questions:

  • Does it make sense to add "Pending" users to both the network admin users list table and the individual site users list table?
  • If yes, do "Pending" users display in the list by default or only when "Pending" is selected.
  • If no, what other interface would make sense?
  • What actions should be available for a pending user? Resend, cancel/delete, manually confirm?

I'd be okay with starting to push on this to be in a place for the next cycle or two.

#31 @dd32
3 years ago

I ran into this a few days ago on a large network, only after realising I'd invited the wrong person to be an Admin.. and couldn't find a way to cancel the request..

Does it make sense to add "Pending" users to both the network admin users list table and the individual site users list table?

I kind of expect it in both locations, although I don't feel too strongly about the network admin list.

If yes, do "Pending" users display in the list by default or only when "Pending" is selected.

When Pending is selected IMHO

What actions should be available for a pending user? Resend, cancel/delete, manually confirm?

I'd expect Cancel/Delete, and Manually Confirm as a user with the right caps. I'm not sure how often Resend would be needed, but it makes sense to me - I don't think there's a way to do that at present?

#32 @Ipstenu
3 years ago

although I don't feel too strongly about the network admin list.

I think it's needed since network admins can invite without being on a specific site :)

Other than that, I agree with Dion :)

This ticket was mentioned in Slack in #core-multisite by coreymckrill. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.