Smilies should not be placed inside of pre or code tags

[Viper007Bond]

Smilies should ignore content inside of <pre> and <code> tags. The author likely is posting code and doesn't need smilies messing it up.

[solarissmoke]

Don't mess with smilies in code and pre blocks

[Viper007Bond]

We'll need to make sure to run any patch through unit tests of course BTW. Gotta make sure it's not significantly slower, etc.

[westi]

Replying to Viper007Bond:

We'll need to make sure to run any patch through unit tests of course BTW. Gotta make sure it's not significantly slower, etc.

Indeed, unfortunately we don't have any similes tests yet - ​http://unit-tests.trac.wordpress.org/browser/wp-testcase/test_includes_formatting.php

Anyone fancy writing some ;)

[jakub.tyrcha]

See ​http://gsoc.svn.wordpress.org/2011/jakub.tyrcha for unit tests testing this and a few more things

[jakub.tyrcha]

I'm pretty sure it fails on the line containing <code style="color:#fff">

[westi]

Replying to jakub.tyrcha:

See ​http://gsoc.svn.wordpress.org/2011/jakub.tyrcha for unit tests testing this and a few more things

Please could you create a ticket in the ​unit-tests trac and attach the patch there too.

[SergeyBiryukov]

#23757 was marked as a duplicate.

[SergeyBiryukov]

Related: #20124, #25303

[nacin]

Needs unit tests. In here: ​http://core.trac.wordpress.org/browser/trunk/tests/phpunit/tests/formatting/Smilies.php.

[mdbitz]

Unit Tests and Consolidated Smilies patch can be found in related ticket #20124

[wonderboymusic]

In 26191:

Don't place smilies inside of pre or code tags. Don't skip smilie after a smilie with an 8 in it. Fix regular expression used for smiley translations to work when there is only one registered emoticon.

Props solarissmoke, soulseekah, mdbitz, yonasy. ht to mdbitz for the Unit Tests and a comprehensive patch.
Fixes #16448, #20124, #25303.