WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 5 months ago

Last modified 5 months ago

#16448 closed enhancement (fixed)

Smilies should not be placed inside of pre or code tags

Reported by: Viper007Bond Owned by: wonderboymusic
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.1
Component: Formatting Keywords: has-patch needs-testing needs-refresh needs-unit-tests
Focuses: Cc:

Description

Smilies should ignore content inside of <pre> and <code> tags. The author likely is posting code and doesn't need smilies messing it up.

Attachments (1)

16448.diff (1.3 KB) - added by solarissmoke 3 years ago.
Don't mess with smilies in code and pre blocks

Download all attachments as: .zip

Change History (15)

comment:1 solarissmoke3 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

solarissmoke3 years ago

Don't mess with smilies in code and pre blocks

comment:2 follow-up: Viper007Bond3 years ago

We'll need to make sure to run any patch through unit tests of course BTW. Gotta make sure it's not significantly slower, etc.

comment:3 in reply to: ↑ 2 westi3 years ago

Replying to Viper007Bond:

We'll need to make sure to run any patch through unit tests of course BTW. Gotta make sure it's not significantly slower, etc.

Indeed, unfortunately we don't have any similes tests yet - http://unit-tests.trac.wordpress.org/browser/wp-testcase/test_includes_formatting.php

Anyone fancy writing some ;)

comment:4 follow-up: jakub.tyrcha3 years ago

See http://gsoc.svn.wordpress.org/2011/jakub.tyrcha for unit tests testing this and a few more things

comment:5 jakub.tyrcha3 years ago

I'm pretty sure it fails on the line containing <code style="color:#fff">

comment:6 in reply to: ↑ 4 westi3 years ago

Replying to jakub.tyrcha:

See http://gsoc.svn.wordpress.org/2011/jakub.tyrcha for unit tests testing this and a few more things

Please could you create a ticket in the unit-tests trac and attach the patch there too.

comment:7 c3mdigital8 months ago

  • Keywords needs-refresh added

comment:8 SergeyBiryukov7 months ago

#23757 was marked as a duplicate.

comment:11 mdbitz5 months ago

Unit Tests and Consolidated Smilies patch can be found in related ticket #20124

comment:12 mdbitz5 months ago

  • Cc matt@… added

comment:13 wonderboymusic5 months ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 26191:

Don't place smilies inside of pre or code tags. Don't skip smilie after a smilie with an 8 in it. Fix regular expression used for smiley translations to work when there is only one registered emoticon.

Props solarissmoke, soulseekah, mdbitz, yonasy. ht to mdbitz for the Unit Tests and a comprehensive patch.
Fixes #16448, #20124, #25303.

comment:14 wonderboymusic5 months ago

  • Milestone changed from Awaiting Review to 3.8
Note: See TracTickets for help on using tickets.