Menu Items aren't deleting on page being trashed, only when deleted

[jeremyatignition]

The linked menu item for a page isn't removed when the page is trashed.

[solarissmoke]

This is because _wp_delete_post_menu_item is only hooked to the delete_post action.

Patch adds the same hook to the trash action. Of course this means that if you restore the post then the menu item has to be restored manually if you still want it - but this seems better than having to delete the menu item manually when you trash a post.

[SergeyBiryukov]

Related: #19415

[jpyper]

Just wanted to say this works like a charm for me. I can even add that line into a plugin or my functions.php file.

[SergeyBiryukov]

#28765 was marked as a duplicate.

[svinqvmraka]

I can also confirm that the patch still works perfectly on 4.1.

[swissspidy]

Patch needs a refresh.

What if you're just temporarily trashing a page to untrash it again a bit later?

I think a menu item of a trashed object should show as invalid in the admin and not show up at all on the front-end.

[Jpyper]

Honest question: when is it better to trash a page rather than just set it to draft to temporarily remove it? I'd consider trashing a page as intent to never get it back. This may just be my opinion/preference though and not the majority of other user's way.

[swissspidy]

Replying to Jpyper:

Honest question: when is it better to trash a page rather than just set it to draft to temporarily remove it? I'd consider trashing a page as intent to never get it back. This may just be my opinion/preference though and not the majority of other user's way.

True. I was just giving an example. There's a reason why this wasn't implemented for trashed pages. My suggestion is still the same as pages or posts can be untrashed.

[Jpyper]

Replying to swissspidy:

Replying to Jpyper:

Honest question: when is it better to trash a page rather than just set it to draft to temporarily remove it? I'd consider trashing a page as intent to never get it back. This may just be my opinion/preference though and not the majority of other user's way.

True. I was just giving an example. There's a reason why this wasn't implemented for trashed pages. My suggestion is still the same as pages or posts can be untrashed.

I don't know if I've ever seen that "invalid" menu item scenario come up before, I just had to look it up. That actually sounds better. The main goal is to have the menu item not show on the front end if it's object was trashed. It would be nice to make it easy to reinstate that menu item just by bringing the object back (as long as it's not removed from the DB, obviously).

[swissspidy]

The main goal is to have the menu item not show on the front end if it's object was trashed. It would be nice to make it easy to reinstate that menu item just by bringing the object back (as long as it's not removed from the DB, obviously).

That's how it's currently working. When you trash a page, the menu item isn't shown on the front-end.

19038.diff​ sets the 'Invalid' flag in the admin to any menu items which have trashed parent objects. The same flag is set when the post type does not exist anymore.

Needs UX review. Perhaps a red warning is too much in this case.

[swissspidy]

I think a menu item of a trashed object should show as invalid in the admin and not show up at all on the front-end.

Just ran into this again. When I add a page or post to the menu and trash it, the menu item is still visible on the front-end. The permalink changes to http://src.wordpress-develop.dev/<slug>__trashed/ as expected because the slug changes when trashing. There's no indication when editing the menu that the post/page is trashed either.

[swissspidy]

19038.2.diff​ still applies cleanly. A trashed page isn't displayed in the nav menu anymore.

Here's how a deleted page is shown in the menu editor with the patch applied.

[swissspidy]

adds unit test

[swissspidy]

In 38744:

Menus: Do not show trashed posts in nav menus.

Trashed posts cannot be accessed by site visitors and thus should not be visible on the front end. By marking menu items of trashed posts as invalid, they are excluded from the output.

Props solarissmoke, swissspidy.
Fixes #19038.