WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 18 months ago

#19061 closed defect (bug) (fixed)

.pinkynail image toggling is reversed for single file uploads

Reported by: SergeyBiryukov Owned by:
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.2.1
Component: Upload Keywords:
Focuses: Cc:

Description

When a single file is uploaded on "Upload New Media" screen, .pinkynail image toggling is reversed. It's displayed when the file info box is expanded, and is hidden when the box is minimized (see the screenshots). Should be vice versa.

Attachments (2)

19061.expanded.png (11.7 KB) - added by SergeyBiryukov 2 years ago.
19061.minimized.png (8.8 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 solarissmoke2 years ago

Looking at the code, it seems that the intention was that when there is only one item, the toggle bar doesn't show at all:

// Just one file, no need for collapsible part
if ( one.length == 1 ) {
	jQuery('.slidetoggle', one).slideDown(500).siblings().addClass('hidden').filter('.toggle').toggle();
}

However the "hidden" class gets overwritten by the inline styling applied by toggle() and then the pinknail and show/hide link show when then shouldn't.

comment:2 helenyhou18 months ago

  • Keywords reporter-feedback added

Is this still happening? I just tested it and seems to either not have previously happened or have gotten fixed somewhere.

comment:3 SergeyBiryukov18 months ago

  • Component changed from UI to Upload
  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 3.3
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [19247].

Note: See TracTickets for help on using tickets.