Opened 13 years ago
Closed 13 years ago
#19338 closed defect (bug) (fixed)
Welcome Panel and no JS don't mix well.
Reported by: | duck_ | Owned by: | nacin |
---|---|---|---|
Milestone: | 3.3 | Priority: | high |
Severity: | major | Version: | 3.3 |
Component: | Administration | Keywords: | has-patch 2nd-opinion |
Focuses: | Cc: |
Description
The welcome panel (#11651) takes up most, if not all, of the dashboard whilst visible. Unfortunately for users without JavaScript it is currently impossible to dismiss it (via the UI).
Quick patch is to hide the dismiss links when no-JS. This would be like #17766, but this time it's a screen filling panel and not a smaller metabox that cannot be dismissed.
Another quick patch is to hide the Welcome Panel when no-JS. This kind of sucks.
Also attached is a quick attempt at probably the best solution: no-JS dismiss fallback. This is a GET handler in wp_dashboard_setup() to hide the panel if requested which is acted upon when visiting index.php?action=dismiss-welcome-panel
.
Attachments (4)
Change History (11)
#3
follow-up:
↓ 5
@
13 years ago
19338.diff works for me.
Note that no-JS users have no means to bring back the welcome screen once it is dismissed since Screen Options is not shown for no-JS.
#4
@
13 years ago
Also note that if this happens after #19127 it will need tweaking (or vice versa) due to the change in data storage proposed there.
#5
in reply to:
↑ 3
@
13 years ago
Replying to ryan:
Note that no-JS users have no means to bring back the welcome screen once it is dismissed since Screen Options is not shown for no-JS.
I think that's fine. If people complain (doubt they will) we can look into alternate measure in 3.4.
The no-js solution should be like everywhere else: show the links, but do a page refresh to submit the change rather than js.