WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#19338 closed defect (bug) (fixed)

Welcome Panel and no JS don't mix well.

Reported by: duck_ Owned by: nacin
Milestone: 3.3 Priority: high
Severity: major Version: 3.3
Component: Administration Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

The welcome panel (#11651) takes up most, if not all, of the dashboard whilst visible. Unfortunately for users without JavaScript it is currently impossible to dismiss it (via the UI).

Quick patch is to hide the dismiss links when no-JS. This would be like #17766, but this time it's a screen filling panel and not a smaller metabox that cannot be dismissed.

Another quick patch is to hide the Welcome Panel when no-JS. This kind of sucks.

Also attached is a quick attempt at probably the best solution: no-JS dismiss fallback. This is a GET handler in wp_dashboard_setup() to hide the panel if requested which is acted upon when visiting index.php?action=dismiss-welcome-panel.

Attachments (4)

hide-dismiss-links.diff (1.0 KB) - added by duck_ 4 years ago.
hide-entire-welcome-panel.diff (451 bytes) - added by duck_ 4 years ago.
19338.diff (2.1 KB) - added by duck_ 4 years ago.
19338.002.diff (2.1 KB) - added by duck_ 4 years ago.
To line up with latest patch (.3.diff) on #19127

Download all attachments as: .zip

Change History (11)

@duck_4 years ago

@duck_4 years ago

comment:1 @jane4 years ago

The no-js solution should be like everywhere else: show the links, but do a page refresh to submit the change rather than js.

comment:2 @jane4 years ago

  • Priority changed from normal to high
  • Severity changed from normal to major

comment:3 follow-up: @ryan4 years ago

19338.diff works for me.

Note that no-JS users have no means to bring back the welcome screen once it is dismissed since Screen Options is not shown for no-JS.

comment:4 @duck_4 years ago

Also note that if this happens after #19127 it will need tweaking (or vice versa) due to the change in data storage proposed there.

comment:5 in reply to: ↑ 3 @jane4 years ago

Replying to ryan:

Note that no-JS users have no means to bring back the welcome screen once it is dismissed since Screen Options is not shown for no-JS.

I think that's fine. If people complain (doubt they will) we can look into alternate measure in 3.4.

@duck_4 years ago

To line up with latest patch (.3.diff) on #19127

comment:6 @nacin4 years ago

  • Owner set to nacin
  • Status changed from new to accepted

Let's do ?welcome=0 or 1. Dismiss is 0. 1 can allow for it to appear again. Either 0 or 1 gets stored directly in user Meta.

Tackling this with #19127.

comment:7 @nacin4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [19418]:

Change show/hide storage mechanism for show_welcome_panel. 0 = hide, 1 = show, 2 = show if the multisite owner. Make welcome panel dismissable without JS (openable too via the URL). fixes #19338, fixes #19127.

Note: See TracTickets for help on using tickets.