WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 7 months ago

#19724 new defect (bug)

Sites with IDN domains can't be created (bug #15554 continuation)

Reported by: qdinar Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.3
Component: Networks and Sites Keywords: needs-patch
Focuses: multisite Cc:

Description

registration of new site with idn domain by unknown/new users themselves is not possible.
(though creation of new site in wp-admin/network/site-new.php page is possible, by patch given in bug #15554 , i have just now tested it.)

also let i mention that site domain is written (and would be requested to enter, if would be fixed without punycode to unicode conversion) in punicode form in wp-signup.php page, that is not acceptable for wordpress.

i have attached differences i made to wp 3.0.4 to make idn domains working and also to show and accept them in human readable format in wp-signup.php page . link to the differences file i attached to/in previous bug report on/to this topic: http://core.trac.wordpress.org/attachment/ticket/15554/diff304-blogo.txt .

Attachments (2)

wp-3.3-idn-signup.txt (1.8 KB) - added by qdinar 5 years ago.
wp-3.3-idn-signup.diff (4.0 KB) - added by qdinar 5 years ago.

Download all attachments as: .zip

Change History (15)

#1 @ocean90
5 years ago

  • Keywords needs-testing added; idn signup registration punycode unicode removed

#2 @qdinar
5 years ago

i would change "component" from "general" to I18N or Multisite.

i am now going to make same changes as in the "diff" to v. 3.3 .

#3 @qdinar
5 years ago

i [will] attach differences [i] made to v 3.3.
but this do not work at my installation, i have segfault and premature end of script headers errors.

#4 @qdinar
5 years ago

idn.default_charset=UTF-8
php option to make php5-idn working.

#5 @SergeyBiryukov
5 years ago

  • Component changed from General to Multisite
  • Milestone changed from Awaiting Review to 3.4

#6 @qdinar
5 years ago

i will attach same [my] diff in correct ("unified") format, i could not patch my old diff, so read about diff and patch usage. i hope this diff will be highlited in this site.

#7 @SergeyBiryukov
5 years ago

  • Keywords has-patch added

#8 follow-up: @kawauso
5 years ago

idn_to_utf8 (idn_to_unicode) and idn_to_ascii are only available in PHP 5.3 and the intl PECL library, so those would need drop-in compatibility functions I believe.

#9 @SergeyBiryukov
4 years ago

  • Keywords needs-refresh added
  • Milestone changed from 3.4 to Future Release

#11 @jeremyfelt
3 years ago

  • Component changed from Multisite to Networks and Sites
  • Focuses multisite added

#12 @chriscct7
11 months ago

  • Keywords needs-patch added; needs-testing has-patch needs-refresh removed

Per comment:8 the current patch isn't usable

#13 in reply to: ↑ 8 @qdinar
7 months ago

Replying to kawauso:

idn_to_utf8 (idn_to_unicode) and idn_to_ascii are only available in PHP 5.3 and the intl PECL library, so those would need drop-in compatibility functions I believe.

i searched for php punycode functions and found several, 4 years ago, but did not post about them here. i thought it is not hard to search and find them if anybody want to use them. but this time i post some links and info and questions.

i have found several libraries this time:

GPL : https://phlymail.com/en/downloads/idna-convert.html -> http://idnaconv.net/get-it.html -> https://github.com/phlylabs/idna-convert

MIT: http://www.zedwood.com/article/php-idn-punycode-converter -> https://github.com/mk-j/PHP_IDN_Punycode

bsd?: https://github.com/true/php-punycode

MIT: https://code.google.com/archive/p/punycode-library/downloads

https://ckon.wordpress.com/2010/08/24/punycode-to-unicode-converter-php/

http://belousovv.ru/myscript/phpIDN

how should i or other user submit this library for wordpress? are not they too big for a patch? in which directory it should be installed?

Note: See TracTickets for help on using tickets.