Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#22015 closed defect (bug) (fixed)

Update Core is showing older version in welcome message

Reported by: cais's profile cais Owned by: dd32's profile dd32
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

I noticed this earlier when updating to 3.5-alpha as well as the the latest version as of Sept 27, 2012.

After 'update-core' has been completed and before the Welcome page has been displayed an older (previous?) version of WordPress is being noted in the 'update-core' Welcome message.

Attached is a patch that should correct this using get_bloginfo( 'version', 'display' ) versus the $result variable but I am having trouble actually testing it.

Attachments (1)

update-core.php.patch (25.2 KB) - added by cais 12 years ago.
update-core.php patch for welcome message

Download all attachments as: .zip

Change History (4)

@cais
12 years ago

update-core.php patch for welcome message

#1 @ocean90
12 years ago

  • Component changed from General to Upgrade/Install
  • Milestone changed from Awaiting Review to 3.5

Just noticed the same.

#2 @dd32
12 years ago

  • Keywords has-patch removed

The patch will display the -current- version of WordPress running, not the new version of WordPress updated to. (change the version in $wp_version, hit update, you should see your custom version rather than the new WordPress version)

This is actually due to #11639, update_core() returns the new version number of WordPress, but it's hard-coded to 3.4 at present (It was never updated for 3.4.1 or 3.4.2). Either need to fix that, or add a comment to the release checklist to make sure that version is bumped.

#3 @dd32
12 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In [22227]:

Replace the hard coded version and PHP/MySQL requirements in update-core.php by pulling in the new version.php file during installation. Fixes #22015 #11639. See #21789

Note: See TracTickets for help on using tickets.