WordPress.org

Make WordPress Core

Opened 17 months ago

Last modified 8 months ago

#22623 new defect (bug)

Some string tweaks - duplicity, context, mistake

Reported by: pavelevap Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: I18N Keywords:
Focuses: Cc:

Description

1) String "Path" has a little different meaning for TinyMCE (HTML position) and Multisite list sites column (subdirectory address). Can we have a context?

2) When you click "Deactivate" action link bellow any site (in Multisite admin), site is marked as "Deleted" instead of "Deactivated"? You can "Activate" deleted site? Strange...

3) We have strings "No results found." (twice) and "No matches found." One string would be better instead of three similar strings?

4) String "Show header text with your image." is not accurate. You can show header text without header image.

Attachments (2)

22623.diff (663 bytes) - added by DrewAPicture 17 months ago.
Show header text
22623.network.patch (1.4 KB) - added by SergeyBiryukov 15 months ago.

Download all attachments as: .zip

Change History (27)

comment:1 SergeyBiryukov17 months ago

2) When you click "Deactivate" action link bellow any site (in Multisite admin), site is marked as "Deleted" instead of "Deactivated"? You can "Activate" deleted site? Strange...

Related: #15801, #17164

comment:2 pavelevap17 months ago

Thank you, Sergey! I did not notice these tickets...

DrewAPicture17 months ago

Show header text

comment:3 DrewAPicture17 months ago

22623.diff changes 'Show header text with your image' to 'Show header text', though I'm not sure if that just ends up being a bit redundant as the section title is also 'Header Text'.

comment:4 knutsp17 months ago

  • Cc knut@… added

comment:5 in reply to: ↑ description nacin17 months ago

  • Version changed from trunk to 3.0

Replying to pavelevap:

1) String "Path" has a little different meaning for TinyMCE (HTML position) and Multisite list sites column (subdirectory address). Can we have a context?

Not new. Can we solve this in 3.6?

2) When you click "Deactivate" action link bellow any site (in Multisite admin), site is marked as "Deleted" instead of "Deactivated"? You can "Activate" deleted site? Strange...

Duplicate of #15801 / #17164.

3) We have strings "No results found." (twice) and "No matches found." One string would be better instead of three similar strings?

Confirmed, I see:

x( 'No results found.', 'search results' );
__( 'No results found.' );
__( 'No matches found.' );

Let's evaluate each contexts and work to merge them in 3.6?

4) String "Show header text with your image." is not accurate. You can show header text without header image.

This has been a problem for a long time. Moving the "Version" of this ticket to 3.0 when custom headers gained prominence — which is also around the same time the multisite "Path" string, "Deactivate" for multisite, one of the "No results found." strings, came in.

comment:6 pavelevap17 months ago

No problem, can be solved in 3.6. I will add some more examples...

5) There are similar strings "File doesn’t exist?" and "File “%s” doesn’t exist?".

Also "File is not an image." and "File “%s” is not an image."

Last edited 17 months ago by pavelevap (previous) (diff)

comment:7 pavelevap17 months ago

And for 3.5 we could remove one of following: "Could not read image size." and "Could not read image size"

comment:8 follow-up: pavelevap17 months ago

7) We have strings "Site URL" and "Home URL". And we have also similar strings with the same meaning "Site Address (URL)" and "WordPress Address (URL)". Could we merge them?

See #22771

Last edited 17 months ago by pavelevap (previous) (diff)

comment:9 pavelevap17 months ago

8) We have also similar strings "Alt Text" (media modal) and "Alternative Text" (TinyMCE).

comment:10 pavelevap17 months ago

9) Similar strings: "Create Gallery" and "Create a new gallery"

"Insert gallery" could be replaced with "Insert into page" and "Insert into post".

And for 3.5 we could remove one of these: "Select files" and "Select Files".

comment:11 pavelevap17 months ago

10) TinyMCE string "Copyright © 2003-2011..." should end with 2012 (or 2013 in near future).

Similar strings: "Advanced Rich Editing" and "Advanced use of the Rich Editor"

Similar strings: "Basics of Rich Editing" and "Rich Editing Basics"

Following string is no longer relevant (TinyMCE help): "There is a button in the editor toolbar for inserting images that are already hosted somewhere on the internet. If you have a URL for an image, click this button and enter the URL in the box which appears."

comment:12 pavelevap17 months ago

11) There are 3 similar strings: "Drop files here", "Drop files to upload" and "Drop files anywhere to upload".

Similar strings (maybe not used anywhere): "Add an Image" and "Add images", "Add Video" and "Add Audio" (TinyMCE).

Similar strings: "Error" and "Error " (with space).

String "None" (media link) should have special context.

Same meaning: "Link URL" (old media) and "Link To" (new media modal).

comment:13 pavelevap17 months ago

12) Similar strings: "Use as featured image" (this string is no longer used?) and "Set featured image".

And new string "Set Featured Image".

Last edited 17 months ago by pavelevap (previous) (diff)

comment:14 in reply to: ↑ 8 ; follow-up: SergeyBiryukov17 months ago

Replying to pavelevap:

7) We have strings "Site URL" and "Home URL". And we have also similar strings with the same meaning "Site Address (URL)" and "WordPress Address (URL)". Could we merge them?

Found another issue with them.

On General Settings screen, "WordPress Address (URL)" is siteurl, and "Site Address (URL)" is home. In XML-RPC, it's vice versa: "Site URL" is siteurl and "Home URL" is home (introduced in [21805]).

Would it make sense to replace the XML-RPC strings with the ones from General Settings screen to prevent confusion?

comment:15 in reply to: ↑ 14 SergeyBiryukov17 months ago

Replying to SergeyBiryukov:

Would it make sense to replace the XML-RPC strings with the ones from General Settings screen to prevent confusion?

Moved to #22771.

comment:16 pavelevap17 months ago

Thank you, Sergey! I did not notice it, because in Czech localization I merged these strings as in your patch from 22771. I know this ticket is a little bit mess now :-) We will have to create several new tickets with related problems in the end... There are only some notes found during localization now...

comment:17 pavelevap16 months ago

Strings "Describe this video…" (audio file, media file) are not used anywhere an we can remove them?

String "Random" is used only once, so we do not need context function.

comment:18 SergeyBiryukov16 months ago

13) "Invalid user ID." and "Invalid user ID".

comment:19 SergeyBiryukov16 months ago

  • Milestone changed from Awaiting Review to 3.6

comment:20 pavelevap16 months ago

  • Similar strings: "Don’t forget to click on the Save Changes button when you are finished." and "Don’t forget to click “Save Changes” when you’re done!"
  • We do not need special context function for string "Default: %s" but we need it for "Default". When there is only one string, comments are usually used:
/* translators: Hint */
  • String "This will remove the background image. You will not be able to restore any customizations." is shown bellow button for background and above button for header. There should be the same position.

comment:21 pavelevap16 months ago

Following string works only for posts:

Published <span class=\"count\">(%s)</span>

But there is no context for pages. For posts we have "1 Publikovaný", but for pages we have "1 Publikovaná".

comment:22 SergeyBiryukov15 months ago

22623.network.patch merges two network-related strings added in [14871]. The change is similar to [16921].

Last edited 15 months ago by SergeyBiryukov (previous) (diff)

comment:23 SergeyBiryukov15 months ago

14) "Timezone" and "Time Zone".

comment:24 markjaquith10 months ago

  • Milestone changed from 3.6 to Future Release

SergeyBiryukov — Those network-related strings should have ordered replacements.

comment:25 pavelevap8 months ago

Same strings, different HTML: "Loading&hellip;" and "Loading&#8230;"

Note: See TracTickets for help on using tickets.