Some string tweaks - duplicity, context, mistake

[pavelevap]

1) String "Path" has a little different meaning for TinyMCE (HTML position) and Multisite list sites column (subdirectory address). Can we have a context?

2) When you click "Deactivate" action link bellow any site (in Multisite admin), site is marked as "Deleted" instead of "Deactivated"? You can "Activate" deleted site? Strange...

3) We have strings "No results found." (twice) and "No matches found." One string would be better instead of three similar strings?

4) String "Show header text with your image." is not accurate. You can show header text without header image.

[SergeyBiryukov]

2) When you click "Deactivate" action link bellow any site (in Multisite admin), site is marked as "Deleted" instead of "Deactivated"? You can "Activate" deleted site? Strange...

Related: #15801, #17164

[pavelevap]

Thank you, Sergey! I did not notice these tickets...

[DrewAPicture]

Show header text

[DrewAPicture]

22623.diff changes 'Show header text with your image' to 'Show header text', though I'm not sure if that just ends up being a bit redundant as the section title is also 'Header Text'.

[nacin]

Replying to pavelevap:

1) String "Path" has a little different meaning for TinyMCE (HTML position) and Multisite list sites column (subdirectory address). Can we have a context?

Not new. Can we solve this in 3.6?

2) When you click "Deactivate" action link bellow any site (in Multisite admin), site is marked as "Deleted" instead of "Deactivated"? You can "Activate" deleted site? Strange...

Duplicate of #15801 / #17164.

3) We have strings "No results found." (twice) and "No matches found." One string would be better instead of three similar strings?

Confirmed, I see:

x( 'No results found.', 'search results' );
__( 'No results found.' );
__( 'No matches found.' );

Let's evaluate each contexts and work to merge them in 3.6?

4) String "Show header text with your image." is not accurate. You can show header text without header image.

This has been a problem for a long time. Moving the "Version" of this ticket to 3.0 when custom headers gained prominence — which is also around the same time the multisite "Path" string, "Deactivate" for multisite, one of the "No results found." strings, came in.

[pavelevap]

No problem, can be solved in 3.6. I will add some more examples...

5) There are similar strings "File doesn’t exist?" and "File “%s” doesn’t exist?".

Also "File is not an image." and "File “%s” is not an image."

[pavelevap]

And for 3.5 we could remove one of following: "Could not read image size." and "Could not read image size"

[pavelevap]

7) We have strings "Site URL" and "Home URL". And we have also similar strings with the same meaning "Site Address (URL)" and "WordPress Address (URL)". Could we merge them?

See #22771

[pavelevap]

8) We have also similar strings "Alt Text" (media modal) and "Alternative Text" (TinyMCE).

[pavelevap]

9) Similar strings: "Create Gallery" and "Create a new gallery"

"Insert gallery" could be replaced with "Insert into page" and "Insert into post".

And for 3.5 we could remove one of these: "Select files" and "Select Files".

[pavelevap]

10) TinyMCE string "Copyright © 2003-2011..." should end with 2012 (or 2013 in near future).

Similar strings: "Advanced Rich Editing" and "Advanced use of the Rich Editor"

Similar strings: "Basics of Rich Editing" and "Rich Editing Basics"

Following string is no longer relevant (TinyMCE help): "There is a button in the editor toolbar for inserting images that are already hosted somewhere on the internet. If you have a URL for an image, click this button and enter the URL in the box which appears."

[pavelevap]

11) There are 3 similar strings: "Drop files here", "Drop files to upload" and "Drop files anywhere to upload".

Similar strings (maybe not used anywhere): "Add an Image" and "Add images", "Add Video" and "Add Audio" (TinyMCE).

Similar strings: "Error" and "Error " (with space).

String "None" (media link) should have special context.

Same meaning: "Link URL" (old media) and "Link To" (new media modal).

[pavelevap]

12) Similar strings: "Use as featured image" (this string is no longer used?) and "Set featured image".

And new string "Set Featured Image".

[SergeyBiryukov]

Replying to pavelevap:

7) We have strings "Site URL" and "Home URL". And we have also similar strings with the same meaning "Site Address (URL)" and "WordPress Address (URL)". Could we merge them?

Found another issue with them.

On General Settings screen, "WordPress Address (URL)" is siteurl, and "Site Address (URL)" is home. In XML-RPC, it's vice versa: "Site URL" is siteurl and "Home URL" is home (introduced in [21805]).

Would it make sense to replace the XML-RPC strings with the ones from General Settings screen to prevent confusion?

[SergeyBiryukov]

Replying to SergeyBiryukov:

Would it make sense to replace the XML-RPC strings with the ones from General Settings screen to prevent confusion?

Moved to #22771.

[pavelevap]

Thank you, Sergey! I did not notice it, because in Czech localization I merged these strings as in your patch from 22771. I know this ticket is a little bit mess now :-) We will have to create several new tickets with related problems in the end... There are only some notes found during localization now...

[pavelevap]

Strings "Describe this video…" (audio file, media file) are not used anywhere an we can remove them?

String "Random" is used only once, so we do not need context function.

[SergeyBiryukov]

13) "Invalid user ID." and "Invalid user ID".

[pavelevap]

• Similar strings: "Don’t forget to click on the Save Changes button when you are finished." and "Don’t forget to click “Save Changes” when you’re done!"

• We do not need special context function for string "Default: %s" but we need it for "Default". When there is only one string, comments are usually used:

/* translators: Hint */

• String "This will remove the background image. You will not be able to restore any customizations." is shown bellow button for background and above button for header. There should be the same position.

[pavelevap]

Following string works only for posts:

Published <span class=\"count\">(%s)</span>

But there is no context for pages. For posts we have "1 Publikovaný", but for pages we have "1 Publikovaná".

[SergeyBiryukov]

22623.network.patch​ merges two network-related strings added in [14871]. The change is similar to [16921].

[SergeyBiryukov]

14) "Timezone" and "Time Zone".

[markjaquith]

SergeyBiryukov — Those network-related strings should have ordered replacements.

[pavelevap]

Same strings, different HTML: "Loading…" and "Loading…"

[ocean90]

In 34841:

Image Editor: Merge two error strings.

Props pavelevap.
See #22623.

[SergeyBiryukov]

Same strings, different quotes:

• Need more help? <a href="%s">We got it</a>.
• Need more help? <a href='%s'>We got it</a>.

Make some strings more consistent across the project.

Trac ticket: #22623

[bradparbs]

Opened a PR to make some of these strings more consistent, along with some notes below on the different things brought up in this ticket, most of which have been resolved since this ticket was opened.

---

3) We have strings "No results found." (twice) and "No matches found." One string would be better instead of three similar strings?

Resolved at some point in the past years

4) String "Show header text with your image." is not accurate. You can show header text without header image.

Resolved in patch

5) There are similar strings "File doesn’t exist?" and "File “%s” doesn’t exist?".

File “%s” doesn’t exist? is only used in a depercated function.

5a) Also "File is not an image." and "File “%s” is not an image."

Resolved at some point in the past years

6) And for 3.5 we could remove one of following: "Could not read image size." and "Could not read image size"

Resolved at some point in the past years

7) We have strings "Site URL" and "Home URL". And we have also similar strings with the same meaning "Site Address (URL)" and "WordPress Address (URL)". Could we merge them?

Handled in separate trac ticket

8) We have also similar strings "Alt Text" (media modal) and "Alternative Text" (TinyMCE).

Resolved in patch

9) Similar strings: "Create Gallery" and "Create a new gallery"

Used for different actions

And for 3.5 we could remove one of these: "Select files" and "Select Files".

Resolved at some point in the past years

Similar strings: "Advanced Rich Editing" and "Advanced use of the Rich Editor"

Resolved at some point in the past years

Similar strings: "Basics of Rich Editing" and "Rich Editing Basics"

Resolved at some point in the past years

11) There are 3 similar strings: "Drop files here", "Drop files to upload" and "Drop files anywhere to upload".

Only "Drop files to upload" is used, other strings are for translator context

Similar strings (maybe not used anywhere): "Add an Image" and "Add images", "Add Video" and "Add Audio" (TinyMCE).

Resolved in patch

Similar strings: "Error" and "Error " (with space).

Resolved at some point in the past years

Same meaning: "Link URL" (old media) and "Link To" (new media modal).

Resolved in patch

12) Similar strings: "Use as featured image" (this string is no longer used?) and "Set featured image".

Used for set_featured_image and use_featured_image post type labels

Similar strings: "Don’t forget to click on the Save Changes button when you are finished." and "Don’t forget to click “Save Changes” when you’re done!"

Resolved in patch

13) "Invalid user ID." and "Invalid user ID".

Resolved at some point in the past years

Same strings, different HTML: "Loading…" and "Loading…"

Resolved in patch

Need more help? <a href="%s">We got it</a>. Need more help? <a href='%s'>We got it</a>.

Resolved in patch

[desrosj]

I found this one scrubbing tickets with no milestone. Going to move this back to Future Release for now.

@bradparbs thanks for opening the PR above. I noticed it was closed, though it's not clear why. I spot checked a few of the strings and it seems there could be some fix suggestions above remaining.

Marking this as good-first-bug to hopefully attract someone to report some updated findings so this can be wrapped up and closed out.