WordPress.org

Make WordPress Core

Opened 7 years ago

Last modified 3 weeks ago

#22869 assigned defect (bug)

Large Image Uploads Don't Error Well

Reported by: Ipstenu Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.4
Component: Media Keywords: needs-patch needs-testing
Focuses: Cc:

Description

Related to #22849 but not restricted to the new uploader. Happens on 3.4 and 3.5 in different ways.

To Reproduce: Upload https://objects.dreamhost.com/ipstenu-images/sunset_2_22_11_by_kenshinkyo-d3a6slk.jpeg to your WP install in the media-new.php page

Note: Image is 12600x9450 and 4.9MB

Expected Outcomes:

  • Shared hosted without a lot of memory: Failure, not enough memory, no image uploaded.
  • VPS/Dedicated with tons of memory: Success

Actual outcomes:

  • VPS as expected.
  • Shared not so much. You get the errors as expected however the failure is not correct. The image actually does upload, contrary to the errors, however no thumbnails are made, which then causes a memory problem as the full size image shows when you go to any media library view (in lieu of actual thumbnails). This crashed Chrome (as @markjaquith saw when we were testing Monday night) until I deleted the large images.

The actual issue is on thumbnail creation, so the best 'fix' I can think of is if on failed thumbnail gen, it nukes the master image, but I don't know if that would make sense since some of the thumbnail gen might be on extra image sizes set by themes/plugins. Then again, do you want those if all fail?

Change History (12)

#1 @Ipstenu
7 years ago

Erf. Happens on ALL media uploads, not just the media-new page (if someone could remove "to your WP install in the media-new.php page" from the description please and thank you)

#3 @mikeschroder
5 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.


5 years ago

@Ipstenu
5 years ago

Large Image

#5 @cristovaov
5 years ago

I have encountered this problem on a client his (Site5) shared hosting site with WP 4.0 and WP_Memory_Limit increased to 96M. In this instance the problem also appears to be quite random as in after trying to upload the same file over again it eventually gets uploaded properly.

Main frustration is that the Error message given to the client is quite generic (see attachment) as stated in related tickets. I couldn't find exactly where/how the message gets generated in WP but to have it more specific would be great while a more technical solution is found.

Rookie mistake: I forgot the rename my attachment, if in any way this can be changed? cheers~

Last edited 5 years ago by cristovaov (previous) (diff)

#6 @chriscct7
4 years ago

  • Keywords needs-testing added
  • Owner set to chriscct7
  • Status changed from new to reviewing

I did some work last year on the errors for these at San Fran. This should be retested.

#7 @chriscct7
4 years ago

  • Owner chriscct7 deleted

#8 @chriscct7
4 years ago

  • Owner set to chriscct7
  • Status changed from reviewing to accepted

#9 @chriscct7
4 years ago

  • Owner chriscct7 deleted
  • Status changed from accepted to assigned

This ticket was mentioned in Slack in #core by ipstenu. View the logs.


3 years ago

Note: See TracTickets for help on using tickets.